Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: ui/views/corewm/tooltip_controller.cc

Issue 2652353003: Fix regression: empty tooltip appears in Linux and Chrome OS (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/corewm/tooltip_controller.cc
diff --git a/ui/views/corewm/tooltip_controller.cc b/ui/views/corewm/tooltip_controller.cc
index a52c806a9928e56dd9a4f212c9535e1e456da06d..96d44204d9732e0d7a4d7fa1fc61a43c9e34bde8 100644
--- a/ui/views/corewm/tooltip_controller.cc
+++ b/ui/views/corewm/tooltip_controller.cc
@@ -327,7 +327,7 @@ void TooltipController::UpdateIfRequired() {
}
void TooltipController::ShowTooltip() {
- if (!tooltip_window_)
+ if (!tooltip_window_ || tooltip_text_whitespace_trimmed_.empty())
sky 2017/01/25 23:43:21 Also, how do we end up here with an empty tooltip?
chengx 2017/01/26 01:16:24 Because this function is called from UpdateIfRequi
return;
gfx::Point widget_loc =
curr_mouse_loc_ + tooltip_window_->GetBoundsInScreen().OffsetFromOrigin();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698