Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: chrome/browser/predictors/resource_prefetch_common_unittest.cc

Issue 2652313002: predictors: Move the configuration of speculative prefetch to field trials. (Closed)
Patch Set: Address comments. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_common_unittest.cc
diff --git a/chrome/browser/predictors/resource_prefetch_common_unittest.cc b/chrome/browser/predictors/resource_prefetch_common_unittest.cc
index e7cb118d1b7f365dde4f59e809588c7f703d0075..836e42289a03da307eaa0674ff35fb5e60854c44 100644
--- a/chrome/browser/predictors/resource_prefetch_common_unittest.cc
+++ b/chrome/browser/predictors/resource_prefetch_common_unittest.cc
@@ -12,10 +12,10 @@
#include "chrome/browser/predictors/resource_prefetch_common.h"
#include "chrome/browser/predictors/resource_prefetch_predictor.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/testing_profile.h"
#include "components/prefs/pref_service.h"
+#include "components/variations/variations_params_manager.h"
#include "content/public/test/test_browser_thread.h"
#include "net/base/network_change_notifier.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -51,11 +51,6 @@ class ResourcePrefetchCommonTest : public testing::Test {
profile_->GetPrefs()->SetInteger(prefs::kNetworkPredictionOptions, value);
}
- void SetCommandLineValue(const std::string& value) {
- base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
- switches::kSpeculativeResourcePrefetching, value);
- }
-
void TestIsPrefetchEnabledForOrigin(
const ResourcePrefetchPredictorConfig& config,
PrefetchOrigin origin) {
@@ -103,7 +98,10 @@ TEST_F(ResourcePrefetchCommonTest, IsDisabledByDefault) {
}
TEST_F(ResourcePrefetchCommonTest, EnableLearning) {
- SetCommandLineValue(switches::kSpeculativeResourcePrefetchingLearning);
+ variations::testing::VariationParamsManager params_manager(
+ "dummy-trial", {{kModeParamName, kLearningMode}},
+ {kSpeculativeResourcePrefetchingFeatureName});
+
ResourcePrefetchPredictorConfig config;
EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
TestIsPrefetchLearning(config);
@@ -111,7 +109,10 @@ TEST_F(ResourcePrefetchCommonTest, EnableLearning) {
}
TEST_F(ResourcePrefetchCommonTest, EnablePrefetch) {
- SetCommandLineValue(switches::kSpeculativeResourcePrefetchingEnabled);
+ variations::testing::VariationParamsManager params_manager(
+ "dummy-trial", {{kModeParamName, kPrefetchingMode}},
+ {kSpeculativeResourcePrefetchingFeatureName});
+
ResourcePrefetchPredictorConfig config;
EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
TestIsPrefetchEnabledForOrigin(config, PrefetchOrigin::EXTERNAL);
@@ -120,7 +121,10 @@ TEST_F(ResourcePrefetchCommonTest, EnablePrefetch) {
}
TEST_F(ResourcePrefetchCommonTest, EnablePrefetchExternalOnly) {
- SetCommandLineValue(switches::kSpeculativeResourcePrefetchingEnabledExternal);
+ variations::testing::VariationParamsManager params_manager(
+ "dummy-trial", {{kModeParamName, kExternalPrefetchingMode}},
+ {kSpeculativeResourcePrefetchingFeatureName});
+
ResourcePrefetchPredictorConfig config;
EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
TestIsPrefetchEnabledForOrigin(config, PrefetchOrigin::EXTERNAL);
@@ -132,7 +136,10 @@ TEST_F(ResourcePrefetchCommonTest, EnablePrefetchExternalOnly) {
// Verifies whether prefetching is disabled according to the network type. But
// learning should not be disabled by network.
TEST_F(ResourcePrefetchCommonTest, RespectsNetworkSettings) {
- SetCommandLineValue(switches::kSpeculativeResourcePrefetchingEnabled);
+ variations::testing::VariationParamsManager params_manager(
+ "dummy-trial", {{kModeParamName, kPrefetchingMode}},
+ {kSpeculativeResourcePrefetchingFeatureName});
+
ResourcePrefetchPredictorConfig config;
EXPECT_TRUE(IsSpeculativeResourcePrefetchingEnabled(profile_.get(), &config));
TestIsPrefetchEnabledForOrigin(config, PrefetchOrigin::EXTERNAL);

Powered by Google App Engine
This is Rietveld 408576698