Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2652293002: Address follow-up comments from https://codereview.chromium.org/2626413004/. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
index d15a9ca287ab1eb57adadfe31470e04a34e132a5..23534feac5a5a0b7fb11cabfeade5d0fdae73ac5 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
@@ -177,13 +177,18 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {
boundToUs = mService.bindToCaller();
} catch (RemoteException ex) {
}
- if (!boundToUs) {
- if (mStartCallback != null) {
+
+ if (mStartCallback != null) {
+ if (boundToUs) {
+ mStartCallback.onChildStarted();
+ } else {
mStartCallback.onChildStartFailed();
}
+ mStartCallback = null;
+ }
+
+ if (!boundToUs) {
return;
- } else if (mStartCallback != null) {
- mStartCallback.onChildStarted();
}
// Run the setup if the connection parameters have already been provided. If
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698