third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp - Issue 2652273004: Paint invisible layer content in presence of composited animations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Issue 2652273004: Paint invisible layer content in presence of composited animations. (Closed)

Patch Set: Add tests and sync to head. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

index 24ea040e02bc959476adc07ec161cb6e765bfa8a..9014db1f63ec2fe71b16446ee816311b6f130295 100644

--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

@@ -3118,6 +3118,7 @@ TEST_P(PaintPropertyTreeBuilderTest,

EXPECT_TRUE(properties->transform());

EXPECT_NE(CompositorElementId(),

properties->transform()->compositorElementId());

+ EXPECT_TRUE(properties->transform()->requiresCompositingForAnimation());

}

TEST_P(PaintPropertyTreeBuilderTest, EffectNodeAnimatedHasCompositorElementId) {

@@ -3125,6 +3126,7 @@ TEST_P(PaintPropertyTreeBuilderTest, EffectNodeAnimatedHasCompositorElementId) {

const ObjectPaintProperties* properties = paintPropertiesForElement("target");

EXPECT_TRUE(properties->effect());

EXPECT_NE(CompositorElementId(), properties->effect()->compositorElementId());

+ EXPECT_TRUE(properties->effect()->requiresCompositingForAnimation());

}

TEST_P(PaintPropertyTreeBuilderTest, FloatUnderInline) {