Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

Issue 2652273004: Paint invisible layer content in presence of composited animations. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
index 804bd9e5952f157c54a18bd20b961a10572a52e0..f50da41462464dcd2b1bc3cc99af0a812b75d55d 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
@@ -510,10 +510,11 @@ void PaintPropertyTreeBuilder::updateEffect(
// We should generate a special clip node to represent this expansion.
}
- CompositingReasons compositingReasons =
- CompositingReasonFinder::requiresCompositingForEffectAnimation(style);
wkorman 2017/01/26 22:47:56 This was a bug -- we were assigning the bool resul
wkorman 2017/01/27 03:53:12 Added check for this to test case.
- if (compositingReasons != CompositingReasonNone)
+ CompositingReasons compositingReasons = CompositingReasonNone;
+ if (CompositingReasonFinder::requiresCompositingForEffectAnimation(style)) {
+ compositingReasons = CompositingReasonActiveAnimation;
effectNodeNeeded = true;
+ }
CompositorElementId compositorElementId =
(style.hasCurrentOpacityAnimation() ||

Powered by Google App Engine
This is Rietveld 408576698