Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-success-with-uuid.html

Issue 2652163002: bluetooth: Improve GATT disconnected error message. (Closed)
Patch Set: Merge TOT Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-success-with-uuid.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-success-with-uuid.html b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-success-with-uuid.html
index 6bcaa648020e812363b665eb525014b43a4d33e8..89e6565998c6de2332487a4dbd08226814bc6533 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-success-with-uuid.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-garbage-collection-ran-during-success-with-uuid.html
@@ -8,19 +8,22 @@
promise_test(() => {
let promise;
return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')
- .then(() => requestDeviceWithKeyDown({
- filters: [{services: ['health_thermometer']}]}))
- .then(device => device.gatt.connect())
- .then(gattServer => {
- promise = assert_promise_rejects_with_message(
- gattServer.getPrimaryServices('health_thermometer'),
- new DOMException(
- 'GATT Server disconnected while retrieving services.',
- 'NetworkError'));
- gattServer.disconnect();
- })
- .then(runGarbageCollection)
- .then(() => promise);
+ .then(
+ () => requestDeviceWithKeyDown(
+ {filters: [{services: ['health_thermometer']}]}))
+ .then(device => device.gatt.connect())
+ .then(gattServer => {
+ promise = assert_promise_rejects_with_message(
+ gattServer.getPrimaryServices('health_thermometer'),
+ new DOMException(
+ 'GATT Server is disconnected. ' +
+ 'Cannot retrieve services. ' +
+ '(Re)connect first with `device.gatt.connect`.',
+ 'NetworkError'));
+ gattServer.disconnect();
+ })
+ .then(runGarbageCollection)
+ .then(() => promise);
}, 'Garbage Collection ran during a getPrimaryServices call that succeeds. ' +
'Should not crash.');

Powered by Google App Engine
This is Rietveld 408576698