Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/script-tests/server/garbage-collection-ran-during-success.js

Issue 2652163002: bluetooth: Improve GATT disconnected error message. (Closed)
Patch Set: Merge TOT Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/script-tests/server/garbage-collection-ran-during-success.js
diff --git a/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/garbage-collection-ran-during-success.js b/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/garbage-collection-ran-during-success.js
index 3304c8149324f0780f40fe934cb2a47fb17b0fb6..f2bab5dfb37c62351e251d431cee7152dc13807b 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/garbage-collection-ran-during-success.js
+++ b/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/garbage-collection-ran-during-success.js
@@ -2,21 +2,24 @@
promise_test(() => {
let promise;
return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')
- .then(() => requestDeviceWithKeyDown({
- filters: [{services: ['health_thermometer']}]}))
- .then(device => device.gatt.connect())
- .then(gattServer => {
- promise = assert_promise_rejects_with_message(
- gattServer.CALLS([
- getPrimaryService('health_thermometer')|
- getPrimaryServices()|
- getPrimaryServices('health_thermometer')[UUID]]),
- new DOMException(
- 'GATT Server disconnected while retrieving services.',
- 'NetworkError'));
- gattServer.disconnect();
- })
- .then(runGarbageCollection)
- .then(() => promise);
+ .then(
+ () => requestDeviceWithKeyDown(
+ {filters: [{services: ['health_thermometer']}]}))
+ .then(device => device.gatt.connect())
+ .then(gattServer => {
+ promise = assert_promise_rejects_with_message(
+ gattServer.CALLS(
+ [getPrimaryService('health_thermometer') |
+ getPrimaryServices() |
+ getPrimaryServices('health_thermometer')[UUID]]),
+ new DOMException(
+ 'GATT Server is disconnected. ' +
+ 'Cannot retrieve services. ' +
+ '(Re)connect first with `device.gatt.connect`.',
+ 'NetworkError'));
+ gattServer.disconnect();
+ })
+ .then(runGarbageCollection)
+ .then(() => promise);
}, 'Garbage Collection ran during a FUNCTION_NAME call that succeeds. ' +
'Should not crash.');

Powered by Google App Engine
This is Rietveld 408576698