Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2384)

Unified Diff: dashboard/dashboard/start_try_job.py

Issue 2652043007: Dashboard - Workaround startup.warm.* producing no values with --pageset-repeat=1. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/start_try_job.py
diff --git a/dashboard/dashboard/start_try_job.py b/dashboard/dashboard/start_try_job.py
index 873dca69c620f3e1465643703a563eae0855d803..023fefc1261007024e26305531cab9230ef01ed1 100644
--- a/dashboard/dashboard/start_try_job.py
+++ b/dashboard/dashboard/start_try_job.py
@@ -459,13 +459,18 @@ def _GuessCommandTelemetry(suite, bisect_bot, story_filter, rerun_option):
test_cmd = 'src/tools/perf/run_benchmark'
+ # TODO(simonhatch): Workaround for crbug.com/677843
+ pageset_repeat = 1
+ if 'startup.warm' in suite:
+ pageset_repeat = 2
+
command.extend([
test_cmd,
'-v',
'--browser=%s' % _GuessBrowserName(bisect_bot),
'--output-format=chartjson',
'--upload-results',
- '--pageset-repeat=1',
+ '--pageset-repeat=%d' % pageset_repeat,
'--also-run-disabled-tests',
])
if story_filter:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698