chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc - Issue 2652043004: Remove persisted docked windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

Issue 2652043004: Remove persisted docked windows (Closed)

Patch Set: varkha's comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/chrome_native_app_window_views.cc ('k') | chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

index 2c93bee4efab4c88adbbc1148e8356e725c4cbae..761872a531f2320dddcb6775f7a1a7b608522890 100644

--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.cc

@@ -45,6 +45,7 @@ ChromeNativeAppWindowViewsAura::GetRestorableState(

case ui::SHOW_STATE_DEFAULT:

case ui::SHOW_STATE_MINIMIZED:

case ui::SHOW_STATE_INACTIVE:

+ // TODO(afakhry): Remove Docked Windows in M58.

case ui::SHOW_STATE_DOCKED:

case ui::SHOW_STATE_END:

return ui::SHOW_STATE_NORMAL;

@@ -103,6 +104,8 @@ ui::WindowShowState ChromeNativeAppWindowViewsAura::GetRestoredState() const {

// Use kPreMinimizedShowStateKey in case a window is minimized/hidden.

ui::WindowShowState restore_state = widget()->GetNativeWindow()->GetProperty(

aura::client::kPreMinimizedShowStateKey);

+ // TODO(afakhry): Remove in M58.

if (widget()->GetNativeWindow()->GetProperty(aura::client::kShowStateKey) ==

ui::SHOW_STATE_DOCKED ||

restore_state == ui::SHOW_STATE_DOCKED) {