Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 265203002: Revert of [Autofill] Enable Autofill for dynamically created forms. (Closed)

Created:
6 years, 7 months ago by DaleCurtis
Modified:
6 years, 7 months ago
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Revert of [Autofill] Enable Autofill for dynamically created forms. (https://codereview.chromium.org/242613006/) Reason for revert: Broke DataDrivenHeuristics03 on the Mac debug bots: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.6%20Tests%20%28dbg%29%284%29&number=40752 http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%2010.7%20Tests%20%28dbg%29%284%29&number=23124 Original issue's description: > [Autofill] Enable Autofill for dynamically created forms. > > The appropriate hooks with Blink already exist, this change just causes > the browser to be informed whenever a form is added or changed. > > BUG=360904 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268107 NOTRY=true NOTREECHECKS=true TBR=tsepez,isherman,gcasto Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268113

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -331 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 2 chunks +1 line, -51 lines 0 comments Download
M chrome/renderer/autofill/form_autofill_browsertest.cc View 21 chunks +28 lines, -123 lines 0 comments Download
M components/autofill/content/common/autofill_messages.h View 3 chunks +6 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 3 chunks +3 lines, -7 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 4 chunks +27 lines, -27 lines 0 comments Download
M components/autofill/content/renderer/form_cache.h View 2 chunks +14 lines, -7 lines 0 comments Download
M components/autofill/content/renderer/form_cache.cc View 6 chunks +27 lines, -11 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 3 chunks +5 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 4 chunks +10 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 2 chunks +13 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 15 chunks +29 lines, -71 lines 0 comments Download
M components/autofill/core/common/form_data.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/common/form_data.cc View 1 chunk +0 lines, -14 lines 0 comments Download
A components/autofill/core/common/forms_seen_state.h View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
Created Revert of [Autofill] Enable Autofill for dynamically created forms.
6 years, 7 months ago (2014-05-04 18:32:58 UTC) #1
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 7 months ago (2014-05-04 18:34:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/265203002/1
6 years, 7 months ago (2014-05-04 18:34:17 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-04 18:34:44 UTC) #4
Message was sent while issue was closed.
Change committed as 268113

Powered by Google App Engine
This is Rietveld 408576698