third_party/WebKit/Source/core/loader/FrameFetchContext.cpp - Issue 2651943002: Block subresource requests whose URLs include credentials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2651943002: Block subresource requests whose URLs include credentials. (Closed)

Patch Set: Test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

index d267da610300fd28151cce77f7237c92549ea124..35b4d0f1f9ba3167a5d6ff69dd70de23f6f5de7e 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

@@ -803,6 +803,10 @@ ResourceRequestBlockedReason FrameFetchContext::canRequestInternal(

Deprecation::countDeprecation(

frame()->document(),

UseCounter::RequestedSubresourceWithEmbeddedCredentials);

+ // TODO(mkwst): Remove the runtime-enabled check in M59:

+ // https://www.chromestatus.com/feature/5669008342777856

+ if (RuntimeEnabledFeatures::blockCredentialedSubresourcesEnabled())

+ return ResourceRequestBlockedReason::Origin;

}