third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/credentials.html - Issue 2651943002: Block subresource requests whose URLs include credentials.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/credentials.html

Issue 2651943002: Block subresource requests whose URLs include credentials. (Closed)

Patch Set: Test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/cachestorage/resources/credentials-iframe.html ('k') | third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/thorough/redirect-password.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/credentials.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/credentials.html b/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/credentials.html

index 1bceb40e656e80c1b03732aeb709fad9a8f5b1c4..0bd155673976f133aecd809813d595608768b783 100644

--- a/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/credentials.html

+++ b/third_party/WebKit/LayoutTests/http/tests/cachestorage/serviceworker/credentials.html

@@ -34,12 +34,12 @@ promise_test(function(t) {

});

})

.then(function(data) {

- assert_equals(data.length, 3, 'three entries should be present');

- assert_equals(data.filter(function(url) { return /@/.test(url); }).length, 2,

+ assert_equals(data.length, 1, 'three entries should be present');

+ assert_equals(data.filter(function(url) { return /@/.test(url); }).length, 0,

'two entries should contain credentials');

- assert_true(data.some(function(url) { return /aa:bb@/.test(url); }),

+ assert_false(data.some(function(url) { return /aa:bb@/.test(url); }),

'entry with credentials aa:bb should be present');

- assert_true(data.some(function(url) { return /cc:dd@/.test(url); }),

+ assert_false(data.some(function(url) { return /cc:dd@/.test(url); }),

'entry with credentials cc:dd should be present');

});