Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h

Issue 2651883008: Make content::FeaturePolicy implement WebFeaturePolicy, and use it in blink code (Closed)
Patch Set: Duplicate FP object rather than modifying in-place Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h b/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h
index 116fcaff3720e9f306973ed896b29fa5d8ef1e92..d12244f7db9b89e0e04c776283ddc9ebfcc8e8c4 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h
@@ -6,12 +6,12 @@
#define ConditionalFeaturesForCore_h
#include "core/CoreExport.h"
-#include "platform/feature_policy/FeaturePolicy.h"
+#include "public/platform/WebFeaturePolicy.h"
#include "v8/include/v8.h"
namespace blink {
-class LocalFrame;
+class Frame;
class ScriptState;
// Installs all of the conditionally enabled V8 bindings on the Window object.
@@ -20,8 +20,9 @@ class ScriptState;
// when the V8 context is reused (i.e., after navigation)
CORE_EXPORT void installConditionalFeaturesOnWindow(const ScriptState*);
-CORE_EXPORT bool isFeatureEnabledInFrame(const FeaturePolicy::Feature&,
- const LocalFrame*);
+// Tests whether the feature-policy controlled feature is enabled by policy in
+// the given frame.
+CORE_EXPORT bool isFeatureEnabledInFrame(WebFeaturePolicyFeature, const Frame*);
haraken 2017/03/04 07:36:00 Nit: Another option is to make isFeatureEnabledInF
iclelland 2017/03/06 04:17:40 Thanks, I've been thinking about moving this out o
CORE_EXPORT void registerInstallConditionalFeaturesForCore();

Powered by Google App Engine
This is Rietveld 408576698