third_party/WebKit/Source/core/frame/FeaturePolicyInFrameTest.cpp - Issue 2651883008: Make content::FeaturePolicy implement WebFeaturePolicy, and use it in blink code

Side by Side Diff: third_party/WebKit/Source/core/frame/FeaturePolicyInFrameTest.cpp

Issue 2651883008: Make content::FeaturePolicy implement WebFeaturePolicy, and use it in blink code (Closed)

Patch Set: Cleanup Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/Source/core/dom/SecurityContext.cpp ('K') | « third_party/WebKit/Source/core/dom/SecurityContext.cpp ('k') | third_party/WebKit/Source/core/frame/Frame.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.
raymes 2017/02/13 04:45:22 I may have asked this before, but are we losing si I may have asked this before, but are we losing significant coverage with this being dropped? (I don't necessarily think we are but just want to make sure we've considered it :) iclelland 2017/02/23 20:04:12 I don't think we're losing significant coverage -- Show quoted text On 2017/02/13 04:45:22, raymes wrote: > I may have asked this before, but are we losing significant coverage with this > being dropped? (I don't necessarily think we are but just want to make sure > we've considered it :) I don't think we're losing significant coverage -- this test was for the composition of the policies created from blink code (which are now tested in content, because that's where they are created). It also tests the operation of the isFeatureEnabledInFrame code. If we reinstate this, and we could, just to make sure that isFeatureEnabledInFrame is covered, then we'd probably need to use real features, like fullscreen, rather than the DefaultOn/DefaultOff/DefaultSelf test features. (This test was removed because the set of features is now under the control of content, and it was no longer trivial to add new features from blink.)
4

5 #include "platform/feature_policy/FeaturePolicy.h"

6

7 #include "bindings/core/v8/ConditionalFeatures.h"

8 #include "core/frame/LocalFrame.h"

9 #include "core/testing/DummyPageHolder.h"

10 #include "platform/RuntimeEnabledFeatures.h"

11 #include "testing/gtest/include/gtest/gtest.h"

12

13 // Origin strings used for tests

14 #define ORIGIN_A "https://example.com/"

15 #define ORIGIN_B "https://example.net/"

16

17 namespace blink {

18

19 namespace {

20

21 // This is an example of a feature which should be enabled by default in all

22 // frames.

23 const FeaturePolicy::Feature kDefaultOnFeature{

24 "default-on", FeaturePolicy::FeatureDefault::EnableForAll};

25

26 // This is an example of a feature which should be enabled in top-level frames,

27 // and same-origin child-frames, but must be delegated to all cross-origin

28 // frames explicitly.

29 const FeaturePolicy::Feature kDefaultSelfFeature{

30 "default-self", FeaturePolicy::FeatureDefault::EnableForSelf};

31

32 // This is an example of a feature which should be disabled by default, both in

33 // top-level and nested frames.

34 const FeaturePolicy::Feature kDefaultOffFeature{

35 "default-off", FeaturePolicy::FeatureDefault::DisableForAll};

36

37 } // namespace

38

39 class FeaturePolicyInFrameTest : public ::testing::Test {

40 protected:

41 FeaturePolicyInFrameTest()

42 : m_frameworkWasEnabled(RuntimeEnabledFeatures::featurePolicyEnabled()),

43 m_featureList(

44 {&kDefaultOnFeature, &kDefaultSelfFeature, &kDefaultOffFeature}) {

45 RuntimeEnabledFeatures::setFeaturePolicyEnabled(true);

46 m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600));

47 m_dummyPageHolder->document().setSecurityOrigin(m_originA);

48 }

49

50 ~FeaturePolicyInFrameTest() {

51 RuntimeEnabledFeatures::setFeaturePolicyEnabled(m_frameworkWasEnabled);

52 }

53

54 std::unique_ptr<FeaturePolicy> createFromParentPolicy(

55 const FeaturePolicy* parent,

56 RefPtr<SecurityOrigin> origin) {

57 return FeaturePolicy::createFromParentPolicy(parent, origin, m_featureList);

58 }

59

60 Document& document() { return m_dummyPageHolder->document(); }

61

62 LocalFrame* frame() { return m_dummyPageHolder->document().frame(); }

63

64 RefPtr<SecurityOrigin> m_originA = SecurityOrigin::createFromString(ORIGIN_A);

65 RefPtr<SecurityOrigin> m_originB = SecurityOrigin::createFromString(ORIGIN_B);

66

67 private:

68 const bool m_frameworkWasEnabled;

69

70 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;

71

72 // Contains the list of controlled features, so that we are guaranteed to

73 // have at least one of each kind of default behaviour represented.

74 FeaturePolicy::FeatureList m_featureList;

75 };

76

77 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsInTopLevelFrame) {

78 std::unique_ptr<FeaturePolicy> policy1 =

79 createFromParentPolicy(nullptr, m_originA);

80 document().setFeaturePolicyForTesting(std::move(policy1));

81 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));

82 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame()));

83 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame()));

84 }

85

86 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsInCrossOriginFrame) {

87 std::unique_ptr<FeaturePolicy> policy1 =

88 createFromParentPolicy(nullptr, m_originB);

89 std::unique_ptr<FeaturePolicy> policy2 =

90 createFromParentPolicy(policy1.get(), m_originA);

91 document().setFeaturePolicyForTesting(std::move(policy2));

92 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));

93 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame()));

94 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame()));

95 }

96

97 TEST_F(FeaturePolicyInFrameTest, TestFeatureOverriddenInFrame) {

98 Vector<String> messages;

99 std::unique_ptr<FeaturePolicy> policy1 =

100 createFromParentPolicy(nullptr, m_originA);

101 policy1->setHeaderPolicy(FeaturePolicy::parseFeaturePolicy(

102 "{\"default-off\": [\"self\"], \"default-on\": []}", m_originA.get(),

103 &messages));

104 EXPECT_EQ(0UL, messages.size());

105 document().setFeaturePolicyForTesting(std::move(policy1));

106 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOffFeature, frame()));

107 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));

108 }

109

110 // Ensure that features are enabled / disabled correctly when the FP runtime

111 // flag is turned off.

112 TEST_F(FeaturePolicyInFrameTest, TestFeatureDefaultsWhenFPDisabled) {

113 RuntimeEnabledFeatures::setFeaturePolicyEnabled(false);

114 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));

115 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultSelfFeature, frame()));

116 EXPECT_FALSE(isFeatureEnabledInFrame(kDefaultOffFeature, frame()));

117 }

118

119 // Ensure that feature policy has no effect when the FP runtime flag is turned

120 // off.

121 TEST_F(FeaturePolicyInFrameTest, TestPolicyInactiveWhenFPDisabled) {

122 RuntimeEnabledFeatures::setFeaturePolicyEnabled(false);

123 Vector<String> messages;

124 std::unique_ptr<FeaturePolicy> policy1 =

125 createFromParentPolicy(nullptr, m_originA);

126 policy1->setHeaderPolicy(FeaturePolicy::parseFeaturePolicy(

127 "{\"default-on\": []}", m_originA.get(), &messages));

128 EXPECT_EQ(0UL, messages.size());

129 document().setFeaturePolicyForTesting(std::move(policy1));

130 EXPECT_TRUE(isFeatureEnabledInFrame(kDefaultOnFeature, frame()));

131 }

132

133 } // namespace blink

OLD	NEW