Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc

Issue 2651883006: Add histograms for time to parse start for service worker controlled pages. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
index de5c3ce6e621a8f457d7bea622edd0c784e34075..4b8161f146f720691d29f8e2e2198dacca24e72d 100644
--- a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
@@ -39,6 +39,10 @@ class ServiceWorkerPageLoadMetricsObserverTest
internal::kHistogramServiceWorkerDomContentLoaded, 0);
histogram_tester().ExpectTotalCount(internal::kHistogramServiceWorkerLoad,
0);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramServiceWorkerParseStart, 0);
+ histogram_tester().ExpectTotalCount(
+ internal::kBackgroundHistogramServiceWorkerParseStart, 0);
}
void AssertNoInboxHistogramsLogged() {
@@ -118,6 +122,9 @@ TEST_F(ServiceWorkerPageLoadMetricsObserverTest, WithServiceWorker) {
internal::kHistogramServiceWorkerLoad,
timing.load_event_start.value().InMilliseconds(), 1);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramServiceWorkerParseStart, 1);
+
AssertNoInboxHistogramsLogged();
}
@@ -151,6 +158,8 @@ TEST_F(ServiceWorkerPageLoadMetricsObserverTest, WithServiceWorkerBackground) {
histogram_tester().ExpectTotalCount(
internal::kHistogramServiceWorkerDomContentLoaded, 0);
histogram_tester().ExpectTotalCount(internal::kHistogramServiceWorkerLoad, 0);
+ histogram_tester().ExpectTotalCount(
+ internal::kBackgroundHistogramServiceWorkerParseStart, 1);
AssertNoInboxHistogramsLogged();
}
@@ -215,4 +224,6 @@ TEST_F(ServiceWorkerPageLoadMetricsObserverTest, InboxSite) {
histogram_tester().ExpectBucketCount(
internal::kHistogramServiceWorkerLoadInbox,
timing.load_event_start.value().InMilliseconds(), 1);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramServiceWorkerParseStart, 1);
}

Powered by Google App Engine
This is Rietveld 408576698