Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 2651843004: Also skip formals when diet parsing in dart2js. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fasta
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -9 lines) Patch
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/dart_parser/lib/src/parser.dart View 2 chunks +17 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
This exposes an important difference between fasta and dart2js: fasta builds up an outline with ...
3 years, 11 months ago (2017-01-24 08:17:28 UTC) #2
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-24 08:56:19 UTC) #3
ahe
3 years, 11 months ago (2017-01-24 09:08:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d90b7e967a5e328ae61fb69fcfe7469fff35218a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698