Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/module.json

Issue 2651843003: DevTools: update console timestamp style (Closed)
Patch Set: ac Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/module.json
diff --git a/third_party/WebKit/Source/devtools/front_end/console/module.json b/third_party/WebKit/Source/devtools/front_end/console/module.json
index e5f5f9bc279e881a8a616210f3d52eed8c100a33..df8a42ce83c41959281c315c90f8a84e952d0711 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/module.json
+++ b/third_party/WebKit/Source/devtools/front_end/console/module.json
@@ -106,18 +106,25 @@
{
"type": "setting",
"category": "Console",
- "title": "Show timestamps",
- "settingName": "consoleTimestampsEnabled",
- "settingType": "boolean",
- "defaultValue": false,
+ "title": "Timestamps",
dgozman 2017/01/25 00:51:46 Timestamps:
luoe 2017/01/25 19:43:21 Done.
+ "settingName": "consoleTimestampFormat",
+ "settingType": "enum",
+ "defaultValue": "none",
"options": [
{
- "value": true,
- "title": "Show timestamps"
+ "title": "Hide timestamps",
+ "text": "None",
+ "value": "none"
},
{
- "value": false,
- "title": "Hide timestamps"
+ "title": "Full",
+ "text": "Full (yyyy-MM-dd HH:mm:ss.fff)",
dgozman 2017/01/25 00:51:46 I'd make text "Full", while showing the format in
luoe 2017/01/25 19:43:21 Done.
+ "value": "full"
+ },
+ {
+ "title": "Short",
+ "text": "Short (HH:mm:ss.fff)",
dgozman 2017/01/25 00:51:46 Same here.
luoe 2017/01/25 19:43:21 Done.
+ "value": "short"
}
]
},

Powered by Google App Engine
This is Rietveld 408576698