DevTools: update console timestamp style

third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

 /*
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 798 matching lines @@
   /**
    * @return {boolean}
    */
   matchesFilterRegex(regexObject) {
     regexObject.lastIndex = 0;
     var text = this.contentElement().deepTextContent();
     return regexObject.test(text);
   }
 
   /**
-   * @param {boolean} show
+   * @param {!Console.ConsoleViewMessage.TimestampFormat} format
    */
-  updateTimestamp(show) {
+  updateTimestamp(format) {

[dgozman, 2017/01/25 00:51:46]

Instead of passing format, grab it from the setting right here.

[luoe, 2017/01/25 19:43:21]

Done.

     if (!this._contentElement)
       return;
 
-    if (show && !this.timestampElement) {
-      this.timestampElement = createElementWithClass('span', 'console-timestamp');
-      this.timestampElement.textContent = (new Date(this._message.timestamp)).toConsoleTime() + ' ';
+    if (format !== Console.ConsoleViewMessage.TimestampFormat.None) {
+      var timestampText = formatTimestamp(this._message.timestamp, format);
+      if (!this.timestampElement)

[dgozman, 2017/01/25 00:51:46]

_timestampElement

[luoe, 2017/01/25 19:43:21]

Done.

+        this.timestampElement = createElementWithClass('span', 'console-timestamp');
+      this.timestampElement.textContent = timestampText + ' ';
+      this.timestampElement.title = timestampText;
       this._contentElement.insertBefore(this.timestampElement, this._contentElement.firstChild);
-      return;
+    } else if (this.timestampElement) {
+      this.timestampElement.remove();
+      delete this.timestampElement;
     }
 
-    if (!show && this.timestampElement) {
-      this.timestampElement.remove();
-      delete this.timestampElement;
+    /**
+     * @param {number} timestamp
+     * @param {!Console.ConsoleViewMessage.TimestampFormat} format
+     * @return {string}
+     */
+    function formatTimestamp(timestamp, format) {
+      var date = new Date(timestamp);
+      var yymmdd = date.getFullYear() + '-' + leadZero(date.getMonth() + 1, 2) + '-' + leadZero(date.getDate(), 2);
+      var hhmmssfff = leadZero(date.getHours(), 2) + ':' + leadZero(date.getMinutes(), 2) + ':' +
+          leadZero(date.getSeconds(), 2) + '.' + leadZero(date.getMilliseconds(), 3);
+      if (format === Console.ConsoleViewMessage.TimestampFormat.Full)
+        return yymmdd + ' ' + hhmmssfff;
+      return hhmmssfff;
+
+      /**
+       * @param {number} value
+       * @param {number} length
+       * @return {string}
+       */
+      function leadZero(value, length) {
+        var valueString = value.toString();
+        var padding = length - valueString.length;
+        return padding <= 0 ? valueString : '0'.repeat(padding) + valueString;
+      }
     }
   }
 
   /**
    * @return {number}
    */
   nestingLevel() {
     return this._nestingLevel;
   }
 
@@ skipping 43 matching lines @@
                                         consoleMessage.type === SDK.ConsoleMessage.MessageType.Trace ||
                                         consoleMessage.level === SDK.ConsoleMessage.MessageLevel.Warning);
     if (target && shouldIncludeTrace)
       formattedMessage = this._buildMessageWithStackTrace(consoleMessage, target, this._linkifier);
     else if (this._message.type === SDK.ConsoleMessage.MessageType.Table)
       formattedMessage = this._buildTableMessage(this._message);
     else
       formattedMessage = this._buildMessage(consoleMessage);
     contentElement.appendChild(formattedMessage);
 
-    this.updateTimestamp(Common.moduleSetting('consoleTimestampsEnabled').get());
+    this.updateTimestamp(Common.moduleSetting('consoleTimestampFormat').get());
     return this._contentElement;
   }
 
   /**
    * @return {!Element}
    */
   toMessageElement() {
     if (this._element)
       return this._element;
 
@@ skipping 67 matching lines @@
   repeatCount() {
     return this._repeatCount || 1;
   }
 
   resetIncrementRepeatCount() {
     this._repeatCount = 1;
     if (!this._repeatCountElement)
       return;
 
     this._repeatCountElement.remove();
+    if (this._contentElement)
+      this._contentElement.classList.remove('repeated-message');
     delete this._repeatCountElement;
   }
 
   incrementRepeatCount() {
     this._repeatCount++;
     this._showRepeatCountElement();
   }
 
   _showRepeatCountElement() {
     if (!this._contentElement)
@@ skipping 166 matching lines @@
     }
 
     if (start !== string.length)
       formattedResult.appendChild(Components.linkifyStringAsFragment(string.substring(start)));
 
     return formattedResult;
   }
 };
 
 /**
+ * @enum {string}
+ */
+Console.ConsoleViewMessage.TimestampFormat = {
+  None: 'none',
+  Full: 'full',
+  Short: 'short'
+};
+
+/**
  * @unrestricted
  */
 Console.ConsoleGroupViewMessage = class extends Console.ConsoleViewMessage {
   /**
    * @param {!SDK.ConsoleMessage} consoleMessage
    * @param {!Components.Linkifier} linkifier
    * @param {number} nestingLevel
    */
   constructor(consoleMessage, linkifier, nestingLevel) {
     console.assert(consoleMessage.isGroupStartMessage());
@@ skipping 26 matching lines @@
   toMessageElement() {
     if (!this._element) {
       super.toMessageElement();
       this._expandGroupIcon = UI.Icon.create('', 'expand-group-icon');
       this._contentElement.insertBefore(this._expandGroupIcon, this._contentElement.firstChild);
       this.setCollapsed(this._collapsed);
     }
     return this._element;
   }
 };