DevTools: update console timestamp style

third_party/WebKit/Source/devtools/front_end/platform/utilities.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 379 matching lines @@
 };
 
 /**
  * @return {string}
  */
 Date.prototype.toISO8601Compact = function() {
   /**
    * @param {number} x
    * @return {string}
    */
   function leadZero(x) {

[chenwilliam, 2017/01/24 03:32:13]

Not related to your change, but why is this called differently than leadZero2
below?

[luoe, 2017/01/24 23:16:19]

Doesn't seem to have a good reason.  I left this one alone and wrote a new
leadZero() in ConsoleViewMessage.

     return (x > 9 ? '' : '0') + x;
   }
   return this.getFullYear() + leadZero(this.getMonth() + 1) + leadZero(this.getDate()) + 'T' +
       leadZero(this.getHours()) + leadZero(this.getMinutes()) + leadZero(this.getSeconds());
 };
 
 /**
- * @return {string}
+ * @return {!Object<string, string>}
  */
 Date.prototype.toConsoleTime = function() {

[chenwilliam, 2017/01/24 03:32:13]

I would just remove this method and create a utility method in the Console class
since this method isn't used outside of Console. 

If there's a use case for re-using in another module and want to keep it in
here, I think it's better to split it up into two functions (e.g.
Date.prototype.toHourMinuteSecond() and ...toYearMonthDay()). AFAICT, there's
nothing specific to Console.

[luoe, 2017/01/24 23:16:19]

No other need right now.  Moved inline into ConsoleViewMessage.

   /**
    * @param {number} x
    * @return {string}
    */
   function leadZero2(x) {
     return (x > 9 ? '' : '0') + x;
   }
 
   /**
    * @param {number} x
    * @return {string}
    */
   function leadZero3(x) {
     return '0'.repeat(3 - x.toString().length) + x;
   }
 
-  return this.getFullYear() + '-' + leadZero2(this.getMonth() + 1) + '-' + leadZero2(this.getDate()) + ' ' +
-      leadZero2(this.getHours()) + ':' + leadZero2(this.getMinutes()) + ':' + leadZero2(this.getSeconds()) + '.' +
-      leadZero3(this.getMilliseconds());
+  var yearMonthDay = this.getFullYear() + '-' + leadZero2(this.getMonth() + 1) + '-' + leadZero2(this.getDate());
+  var hourMinuteSecond = leadZero2(this.getHours()) + ':' + leadZero2(this.getMinutes()) + ':' +
+      leadZero2(this.getSeconds()) + '.' + leadZero3(this.getMilliseconds());
+  return {yearMonthDay: yearMonthDay, hourMinuteSecond: hourMinuteSecond};
 };
 
 Object.defineProperty(Array.prototype, 'remove', {
   /**
    * @param {!T} value
    * @param {boolean=} firstOnly
    * @return {boolean}
    * @this {Array.<!T>}
    * @template T
    */
@@ skipping 1014 matching lines @@
   function windowLoaded() {
     self.removeEventListener('DOMContentLoaded', windowLoaded, false);
     callback();
   }
 
   if (document.readyState === 'complete' || document.readyState === 'interactive')
     callback();
   else
     self.addEventListener('DOMContentLoaded', windowLoaded, false);
 }