Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2651813006: Set correct type for enum values list (fixes #28341). (Closed)

Created:
3 years, 11 months ago by regis
Modified:
3 years, 11 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set correct type for enum values list (fixes #28341). Add regression test. Update status file. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/23d57d28df0ab470c342e8336108c7b013ba5746

Patch Set 1 #

Patch Set 2 : work in progress #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -14 lines) Patch
M runtime/vm/object_reload.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +22 lines, -8 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/regress_28341_test.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 11 months ago (2017-01-24 20:27:34 UTC) #2
hausner
LGTM.
3 years, 11 months ago (2017-01-24 23:05:02 UTC) #3
regis
3 years, 11 months ago (2017-01-24 23:07:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
23d57d28df0ab470c342e8336108c7b013ba5746 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698