Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2651813003: Teach run-webkit-tests to look for flag-specific platform baselines. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
index 1d0220199d4eef57d524fa5ed17ecede4dc77ff6..d7b4232e301ab81d756d55a4f16c04b565ff3de7 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
@@ -128,14 +128,14 @@ class PortTest(unittest.TestCase):
def test_additional_platform_directory(self):
port = self.make_port(port_name='foo')
- port.default_baseline_search_path = lambda: ['LayoutTests/platform/foo']
+ port.FALLBACK_PATHS = {'': ['foo']}
test_file = 'fast/test.html'
# No additional platform directory
self.assertEqual(
port.expected_baselines(test_file, '.txt'),
[(None, 'fast/test-expected.txt')])
- self.assertEqual(port.baseline_version_dir(), 'LayoutTests/platform/foo')
+ self.assertEqual(port.baseline_version_dir(), '/mock-checkout/third_party/WebKit/LayoutTests/platform/foo')
# Simple additional platform directory
port._options.additional_platform_directory = ['/tmp/local-baselines']
@@ -155,7 +155,10 @@ class PortTest(unittest.TestCase):
# Flag-specific baseline directory
port._options.additional_platform_directory = []
port._options.additional_driver_flag = ['--special-flag']
- self.assertEqual(port.baseline_version_dir(), '/mock-checkout/third_party/WebKit/LayoutTests/flag-specific/special-flag')
+ self.assertEqual(port.baseline_search_path(), [
+ '/mock-checkout/third_party/WebKit/LayoutTests/flag-specific/special-flag/platform/foo',
+ '/mock-checkout/third_party/WebKit/LayoutTests/flag-specific/special-flag',
+ '/mock-checkout/third_party/WebKit/LayoutTests/platform/foo'])
def test_nonexistant_expectations(self):
port = self.make_port(port_name='foo')
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698