Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2651813003: Teach run-webkit-tests to look for flag-specific platform baselines. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1221 matching lines...) Expand 10 before | Expand all | Expand 10 after
1232 return test_configurations 1232 return test_configurations
1233 1233
1234 def warn_if_bug_missing_in_test_expectations(self): 1234 def warn_if_bug_missing_in_test_expectations(self):
1235 return True 1235 return True
1236 1236
1237 def _flag_specific_expectations_files(self): 1237 def _flag_specific_expectations_files(self):
1238 return [self._filesystem.join(self.layout_tests_dir(), 'FlagExpectations ', flag.lstrip('-')) 1238 return [self._filesystem.join(self.layout_tests_dir(), 'FlagExpectations ', flag.lstrip('-'))
1239 for flag in self.get_option('additional_driver_flag', [])] 1239 for flag in self.get_option('additional_driver_flag', [])]
1240 1240
1241 def _flag_specific_baseline_search_path(self): 1241 def _flag_specific_baseline_search_path(self):
1242 # TODO(skobes): Baselines specific to both flag and platform? 1242 flag_dirs = [self._filesystem.join(self.layout_tests_dir(), 'flag-specif ic', flag.lstrip('-'))
1243 return [self._filesystem.join(self.layout_tests_dir(), 'flag-specific', flag.lstrip('-')) 1243 for flag in self.get_option('additional_driver_flag', [])]
1244 for flag in self.get_option('additional_driver_flag', [])] 1244 return [self._filesystem.join(flag_dir, 'platform', platform_dir)
1245 for platform_dir in self.FALLBACK_PATHS[self.version()]
1246 for flag_dir in flag_dirs] + flag_dirs
1245 1247
1246 def expectations_dict(self): 1248 def expectations_dict(self):
1247 """Returns an OrderedDict of name -> expectations strings. 1249 """Returns an OrderedDict of name -> expectations strings.
1248 The names are expected to be (but not required to be) paths in the files ystem. 1250 The names are expected to be (but not required to be) paths in the files ystem.
1249 If the name is a path, the file can be considered updatable for things l ike rebaselining, 1251 If the name is a path, the file can be considered updatable for things l ike rebaselining,
1250 so don't use names that are paths if they're not paths. 1252 so don't use names that are paths if they're not paths.
1251 Generally speaking the ordering should be files in the filesystem in cas cade order 1253 Generally speaking the ordering should be files in the filesystem in cas cade order
1252 (TestExpectations followed by Skipped, if the port honors both formats), 1254 (TestExpectations followed by Skipped, if the port honors both formats),
1253 then any built-in expectations (e.g., from compile-time exclusions), the n --additional-expectations options. 1255 then any built-in expectations (e.g., from compile-time exclusions), the n --additional-expectations options.
1254 """ 1256 """
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
1643 1645
1644 def __init__(self, base, args, reference_args=None): 1646 def __init__(self, base, args, reference_args=None):
1645 self.name = base 1647 self.name = base
1646 self.base = base 1648 self.base = base
1647 self.args = args 1649 self.args = args
1648 self.reference_args = args if reference_args is None else reference_args 1650 self.reference_args = args if reference_args is None else reference_args
1649 self.tests = set() 1651 self.tests = set()
1650 1652
1651 def __repr__(self): 1653 def __repr__(self):
1652 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1654 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698