Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2651803004: Fuchsia: Update vm and language status files (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +37 lines, -0 lines 2 comments Download
M tests/language/language.status View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 11 months ago (2017-01-24 18:09:17 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2651803004/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/2651803004/diff/1/runtime/tests/vm/vm.status#newcode52 runtime/tests/vm/vm.status:52: [ $system == fuchsia ] I also got ...
3 years, 11 months ago (2017-01-24 23:51:23 UTC) #3
zra
https://codereview.chromium.org/2651803004/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/2651803004/diff/1/runtime/tests/vm/vm.status#newcode52 runtime/tests/vm/vm.status:52: [ $system == fuchsia ] On 2017/01/24 23:51:23, rmacnak ...
3 years, 11 months ago (2017-01-25 06:00:31 UTC) #4
zra
3 years, 11 months ago (2017-01-25 06:03:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
82bddc361427f27071c35ee27ab75ad1ada19d56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698