Introduce KernelWorldBuilder

Introduce KernelWorldBuilder

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/fb75d5252138b3a8d73203a2539c701e22e6d049

[Johnni Winther, 2017-01-24 14:47:21]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-24 21:16:21]

I'm not sure yet I see where you area headed (and why the KernelWorldBuilder
name), but otherwise the change lgtm.

https://codereview.chromium.org/2651803003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2651803003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:37: /// Interface that
translates between Kernel IR nodes and entities.
is the idea that this will be used to actually build a ClosedWorld based on
Kernel? If so, maybe update the doc? If not, maybe update the name?

[Johnni Winther, 2017-01-25 09:06:14]

On 2017/01/24 21:16:21, Siggi Cherem (dart-lang) wrote:
> I'm not sure yet I see where you area headed (and why the KernelWorldBuilder
> name), but otherwise the change lgtm.
> 

I'm planning to create a KernelWorldBuilderImpl for computing impacts. This will
later implement ResolutionWorldBuilder for the closed world computation.

[Johnni Winther, 2017-01-25 09:08:56]

https://codereview.chromium.org/2651803003/diff/20001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart (right):

https://codereview.chromium.org/2651803003/diff/20001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart:37: /// Interface that
translates between Kernel IR nodes and entities.
On 2017/01/24 21:16:21, Siggi Cherem (dart-lang) wrote:
> is the idea that this will be used to actually build a ClosedWorld based on
> Kernel? If so, maybe update the doc? If not, maybe update the name?

In time the implementation of this interface will also be a
ResolutionWorldBuilder but the user of KernelWorldBuilder shouldn't know.

[Johnni Winther, 2017-01-25 09:16:38]

Description was changed from

==========
Introduce KernelWorldBuilder
==========

to

==========
Introduce KernelWorldBuilder

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fb75d5252138b3a8d73203a2539c701e22e6d049
==========

[Johnni Winther, 2017-01-25 09:16:39]

Committed patchset #2 (id:20001) manually as
fb75d5252138b3a8d73203a2539c701e22e6d049 (presubmit successful).