third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h - Issue 2651793013: Fix incorrectly calculated size/position information for writing-modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2651793013: Fix incorrectly calculated size/position information for writing-modes (Closed)

Patch Set: git rebase-update Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

index 35622c7f22cb78b3cf70c42f8ad3ff528a5ca3f6..b3edfc28276a55846e7dc4d29f35fdd5b73c5288 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

@@ -110,6 +110,7 @@ class CORE_EXPORT NGConstraintSpace final

NGMarginStrut MarginStrut() const { return margin_strut_; }

+ // TODO(glebl): Rename to Offset() or AbsoluteOffset().

NGLogicalOffset BfcOffset() const { return bfc_offset_; }

DEFINE_INLINE_VIRTUAL_TRACE() {}