third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h - Issue 2651793013: Fix incorrectly calculated size/position information for writing-modes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

Issue 2651793013: Fix incorrectly calculated size/position information for writing-modes (Closed)

Patch Set: git rebase-update Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

index 6b48b4acb9695727fc8b6a28704f1757ca973563..a9fe01b750dab61bf787b5286082fe37e2146c7a 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h

@@ -101,7 +101,6 @@ class CORE_EXPORT NGBlockLayoutAlgorithm : public NGLayoutAlgorithm {

// Calculates offset for the provided fragment which is relative to the

// fragment's parent.

NGLogicalOffset CalculateRelativeOffset(const NGBoxFragment& fragment);

NGLogicalOffset GetChildSpaceOffset() const {

return NGLogicalOffset(border_and_padding_.inline_start, content_size_);

}