Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(193)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: cc/resources/DEPS
Issue
2651793007
:
Implemented StructTraits for cc::TextureMailbox (Closed)
Patch Set: c
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
cc/ipc/BUILD.gn
cc/ipc/struct_traits_unittest.cc
cc/ipc/texture_mailbox.mojom
cc/ipc/texture_mailbox.typemap
cc/ipc/texture_mailbox_struct_traits.h
cc/ipc/traits_test_service.mojom
cc/ipc/typemaps.gni
cc/resources/DEPS
cc/resources/texture_mailbox.h
View unified diff
|
Download patch
« no previous file with comments
|
« cc/ipc/typemaps.gni
('k') |
cc/resources/texture_mailbox.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
include_rules = [
2
"+mojo/public/cpp/bindings/struct_traits.h",
sky
2017/01/26 18:42:38
Don't you need to update deps in a BUILD.gn too?
Don't you need to update deps in a BUILD.gn too?
Saman Sami
2017/01/26 18:46:37
Done.
Show quoted text
On 2017/01/26 18:42:38, sky wrote: > Don't you need to update deps in a BUILD.gn too?
Done.
3
]
OLD
NEW
« no previous file with comments
|
« cc/ipc/typemaps.gni
('k') |
cc/resources/texture_mailbox.h »
('j') |
no next file with comments »
Issue 2651793007: Implemented StructTraits for cc::TextureMailbox (Closed)
Created 3 years, 11 months ago by Saman Sami
Modified 3 years, 10 months ago
Reviewers: Fady Samuel, Tom Sepez, danakj, sky, vmpstr
Base URL:
Comments: 12
This is Rietveld
408576698