TypeProvider is only available after a resolution.

TypeProvider is only available after a resolution.

We're moving in the direction of resynthesizing dart:core and dart:async
classes on demand, in the same context as all the other sources. We will
not have a special AnalysisContext for SDK which we can ask TypeProvider
from.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/1ab863347ac05d8b72ac4a4575db1bbbf59eb42b

[Brian Wilkerson, 2017-01-23 20:50:34]

lgtm

https://codereview.chromium.org/2651743005/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/strong_mode_test.dart (right):

https://codereview.chromium.org/2651743005/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/strong_mode_test.dart:60: Future<TestAnalysisResult>
computeAnalysisResult(Source source) async {
I assume that none of the initializations that were moved into this method will
cause a problem if this method is invoked more than once per test.

[scheglov, 2017-01-23 21:26:34]

https://codereview.chromium.org/2651743005/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/strong_mode_test.dart (right):

https://codereview.chromium.org/2651743005/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/strong_mode_test.dart:60: Future<TestAnalysisResult>
computeAnalysisResult(Source source) async {
On 2017/01/23 20:50:34, Brian Wilkerson wrote:
> I assume that none of the initializations that were moved into this method
will
> cause a problem if this method is invoked more than once per test.

They are not, but it is still wasteful.
I changed it to create assertions only once per test.
Thanks.

[scheglov, 2017-01-23 21:26:50]

Description was changed from

==========
TypeProvider is only available after a resolution.

We're moving in the direction of resynthesizing dart:core and dart:async
classes on demand, in the same context as all the other sources. We will
not have a special AnalysisContext for SDK which we can ask TypeProvider
from.

R=brianwilkerson@google.com
BUG=
==========

to

==========
TypeProvider is only available after a resolution.

We're moving in the direction of resynthesizing dart:core and dart:async
classes on demand, in the same context as all the other sources. We will
not have a special AnalysisContext for SDK which we can ask TypeProvider
from.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/1ab863347ac05d8b72ac4a4575db1bbbf59eb42b
==========

[scheglov, 2017-01-23 21:26:51]

Committed patchset #1 (id:1) manually as
1ab863347ac05d8b72ac4a4575db1bbbf59eb42b (presubmit successful).