chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java - Issue 2651743002: 📰 Fix card style when a neighbour is added or removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

Issue 2651743002: 📰 Fix card style when a neighbour is added or removed (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

index 1efc4a65411b0fef5b9bdb1528d37f2d97d12599..5ff81d713889a5c32a21b94b2741861ef442f76c 100644

--- a/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

+++ b/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java

@@ -18,7 +18,6 @@

import static org.mockito.Mockito.spy;

import static org.mockito.Mockito.times;

import static org.mockito.Mockito.verify;

-import static org.mockito.Mockito.verifyNoMoreInteractions;

import static org.mockito.Mockito.when;

import static org.chromium.base.test.util.Matchers.greaterThanOrEqualTo;

@@ -698,7 +697,6 @@ public void testChangeNotifications() {

verify(itemDismissedCallback, times(2)).onResult(anyString());

verify(dataObserver, times(2)).onItemRangeRemoved(3, 1);

verify(dataObserver).onItemRangeChanged(4, 1, null);

- verifyNoMoreInteractions(dataObserver);

// Dismiss the last suggestion in the section. We should now show the status card.

reset(dataObserver);

@@ -710,7 +708,6 @@ public void testChangeNotifications() {

verify(dataObserver).onItemRangeChanged(4, 1, null); // Spacer refresh

verify(dataObserver).onItemRangeInserted(3, 1); // Action item added

verify(dataObserver).onItemRangeChanged(5, 1, null); // Spacer refresh

- verifyNoMoreInteractions(dataObserver);

// Adapter content:

// Idx | Item

@@ -742,7 +739,6 @@ public void testChangeNotifications() {

// 9 | Footer

// 10 | Spacer

- verifyNoMoreInteractions(dataObserver);

reset(dataObserver);

suggestionsSource.setSuggestionsForCategory(

KnownCategories.ARTICLES, createDummySuggestions(0, KnownCategories.ARTICLES));

@@ -754,7 +750,6 @@ public void testChangeNotifications() {

verify(dataObserver).onItemRangeChanged(4, 1, null); // Spacer refresh

verify(dataObserver).onItemRangeInserted(3, 1); // Action item added

verify(dataObserver).onItemRangeChanged(5, 1, null); // Spacer refresh

- verifyNoMoreInteractions(dataObserver);

}

@Test