chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java - Issue 2651743002: 📰 Fix card style when a neighbour is added or removed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java

Issue 2651743002: 📰 Fix card style when a neighbour is added or removed (Closed)

Patch Set: Revert to previous implementation Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/ContentSuggestionsTestUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java

index cde816d5842025ee49a1ada12fd19e4244191000..def5a2a5be04b53e6bc8e54bdd0a72cf67ea6de4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java

@@ -14,9 +14,16 @@

* holders

* @see org.chromium.chrome.browser.ntp.cards.InnerNode#notifyItemChanged(int, Object)

-@IntDef({PartialUpdateId.OFFLINE_BADGE})

+@IntDef({PartialUpdateId.OFFLINE_BADGE, PartialUpdateId.CARD_BACKGROUND})

@Retention(RetentionPolicy.SOURCE)

public @interface PartialUpdateId {

- /** Marks a request to update a suggestion's offline badge */

+ /** Marks a request to update a suggestion's offline badge. */

int OFFLINE_BADGE = 1;

+ /**

+ * Marks a request to update a card's background. Will no-op if received by a non card

+ * view holder.

+ * @see org.chromium.chrome.browser.ntp.cards.CardViewHolder#updateLayoutParams()

+ */

+ int CARD_BACKGROUND = 2;

}