IME for Mus: Avoid crash in InitWindowCandidateView().

chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

Index: chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
diff --git a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
index 1c84d3988b895173fd8b6b1841a272104866a5a8..003e7e6fde332c4d44bee3c93f7addedce5ff96e 100644
--- a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
+++ b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
@@ -12,6 +12,7 @@
 #include "ash/wm/window_util.h"
 #include "base/logging.h"
 #include "chrome/browser/chromeos/input_method/mode_indicator_controller.h"
+#include "chrome/browser/ui/ash/ash_util.h"
 #include "ui/base/ime/ime_bridge.h"
 #include "ui/chromeos/ime/infolist_window.h"
 #include "ui/views/widget/widget.h"
@@ -44,12 +45,20 @@ void CandidateWindowControllerImpl::InitCandidateWindowView() {
   if (candidate_window_view_)
     return;
 
-  aura::Window* active_window = ash::wm::GetActiveWindow();
-  candidate_window_view_ =
-      new ui::ime::CandidateWindowView(ash::Shell::GetContainer(
-          active_window ? active_window->GetRootWindow()
-                        : ash::Shell::GetTargetRootWindow(),
-          ash::kShellWindowId_SettingBubbleContainer));
+  // TODO(moshayedi): crbug.com/637416. Setting parent is nullptr in mash is

[sadrul, 2017/01/24 15:59:10]

Can you actually file a new bug specifically for making sure the candidate list
is moved correctly when the window containing the focused text input-client
moves?

+  // just for the sake of not crashing. It doesn't provide the same behaviour
+  // as we have in ChromeOS. For example, candidate pop-up disappears when
+  // dragging the window in mash, but it shouldn't. We should find a better
+  // solution.
+  gfx::NativeView parent = nullptr;
+  if (!chrome::IsRunningInMash()) {
+    aura::Window* active_window = ash::wm::GetActiveWindow();
+    parent = ash::Shell::GetContainer(
+        active_window ? active_window->GetRootWindow()
+                      : ash::Shell::GetTargetRootWindow(),
+        ash::kShellWindowId_SettingBubbleContainer);
+  }
+  candidate_window_view_ = new ui::ime::CandidateWindowView(parent);
   candidate_window_view_->AddObserver(this);
   candidate_window_view_->SetCursorBounds(cursor_bounds_, composition_head_);
   views::Widget* widget = candidate_window_view_->InitWidget();