Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: src/debug/debug.h

Issue 2651683005: [inspector] don't ignore uncaught exception if at least 1 frame isn't blackboxed (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_H_ 5 #ifndef V8_DEBUG_DEBUG_H_
6 #define V8_DEBUG_DEBUG_H_ 6 #define V8_DEBUG_DEBUG_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 // Currently inspector still uses C++ event listener and installs 490 // Currently inspector still uses C++ event listener and installs
491 // more specific event listeners for part of events. Calling of 491 // more specific event listeners for part of events. Calling of
492 // C++ event listener is redundant when more specific event listener 492 // C++ event listener is redundant when more specific event listener
493 // is presented. Other clients can install JavaScript event listener 493 // is presented. Other clients can install JavaScript event listener
494 // (e.g. some of NodeJS module). 494 // (e.g. some of NodeJS module).
495 bool non_inspector_listener_exists() const { 495 bool non_inspector_listener_exists() const {
496 return !event_listener_.is_null() && !event_listener_->IsForeign(); 496 return !event_listener_.is_null() && !event_listener_->IsForeign();
497 } 497 }
498 498
499 bool IsBlackboxed(SharedFunctionInfo* shared); 499 bool IsBlackboxed(SharedFunctionInfo* shared);
500 bool IsExceptionBlackboxed(bool uncaught);
501 bool IsFrameBlackboxed(JavaScriptFrame* frame);
500 502
501 void OnException(Handle<Object> exception, Handle<Object> promise); 503 void OnException(Handle<Object> exception, Handle<Object> promise);
502 504
503 // Constructors for debug event objects. 505 // Constructors for debug event objects.
504 MUST_USE_RESULT MaybeHandle<Object> MakeExecutionState(); 506 MUST_USE_RESULT MaybeHandle<Object> MakeExecutionState();
505 MUST_USE_RESULT MaybeHandle<Object> MakeBreakEvent( 507 MUST_USE_RESULT MaybeHandle<Object> MakeBreakEvent(
506 Handle<Object> break_points_hit); 508 Handle<Object> break_points_hit);
507 MUST_USE_RESULT MaybeHandle<Object> MakeExceptionEvent( 509 MUST_USE_RESULT MaybeHandle<Object> MakeExceptionEvent(
508 Handle<Object> exception, 510 Handle<Object> exception,
509 bool uncaught, 511 bool uncaught,
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 Handle<Code> code); 761 Handle<Code> code);
760 static bool DebugBreakSlotIsPatched(Address pc); 762 static bool DebugBreakSlotIsPatched(Address pc);
761 static void ClearDebugBreakSlot(Isolate* isolate, Address pc); 763 static void ClearDebugBreakSlot(Isolate* isolate, Address pc);
762 }; 764 };
763 765
764 766
765 } // namespace internal 767 } // namespace internal
766 } // namespace v8 768 } // namespace v8
767 769
768 #endif // V8_DEBUG_DEBUG_H_ 770 #endif // V8_DEBUG_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698