Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2651673016: Ignore missing entries in patching map (Closed)

Created:
3 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore missing entries in patching map Some libraries have no patch files, this allows a user of the patch mechanism to skip and not add an explicit entry for such libraries. BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/2a3c83b452073babb0eacd8473b110b649962a27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/lib/src/dart/sdk/patch.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-01-27 21:17:19 UTC) #2
Paul Berry
lgtm
3 years, 10 months ago (2017-01-27 22:51:11 UTC) #3
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-01-27 22:57:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a3c83b452073babb0eacd8473b110b649962a27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698