Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4790)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItemView.java

Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItemView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItemView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItemView.java
index e7ce17d38628c31b0b2813ec0e262dc8c7c8d6bb..cffb2e64f7a4ea2f209747d9cfd19d792da870c7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItemView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItemView.java
@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.ntp;
import android.content.Context;
import android.graphics.drawable.Drawable;
+import android.support.annotation.Nullable;
import android.util.AttributeSet;
import android.view.View;
import android.widget.FrameLayout;
@@ -19,6 +20,7 @@ import org.chromium.chrome.R;
* icon isn't available, displays a rounded rectangle with a single letter in its place.
*/
public class MostVisitedItemView extends FrameLayout {
+ private String mUrl;
/**
* Constructor for inflating from XML.
@@ -35,11 +37,10 @@ public class MostVisitedItemView extends FrameLayout {
}
/**
- * Sets the icon.
+ * Sets the icon, or null to clear it.
*/
- public void setIcon(Drawable icon) {
- ImageView iconView = (ImageView) findViewById(R.id.most_visited_icon);
- iconView.setImageDrawable(icon);
+ public void setIcon(@Nullable Drawable icon) {
+ ((ImageView) findViewById(R.id.most_visited_icon)).setImageDrawable(icon);
}
/**
@@ -49,4 +50,18 @@ public class MostVisitedItemView extends FrameLayout {
findViewById(R.id.offline_badge).setVisibility(
offlineAvailable ? View.VISIBLE : View.INVISIBLE);
}
+
+ /**
+ * Sets the site URL. This is used to identify the view.
+ */
+ public void setUrl(String url) {
+ mUrl = url;
+ }
+
+ /**
+ * Gets the site URL. This is used to identify the view.
+ */
+ public String getUrl() {
+ return mUrl;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698