chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java - Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java

Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home. (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/suggestions_site_tile_grid.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java

index c03118ccbbe36f005c03c0019e227cbd1099afb8..d8f408994183db51b74f1d5a8a79714d6b6bf77d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/favicon/LargeIconBridge.java

@@ -5,6 +5,7 @@

package org.chromium.chrome.browser.favicon;

import android.graphics.Bitmap;

+import android.support.annotation.Nullable;

import android.util.LruCache;

import org.chromium.base.annotations.CalledByNative;

@@ -45,7 +46,8 @@ public class LargeIconBridge {

* @param fallbackColor The fallback color to use if icon is null.

@CalledByNative("LargeIconCallback")

- void onLargeIconAvailable(Bitmap icon, int fallbackColor, boolean isFallbackColorDefault);

+ void onLargeIconAvailable(

+ @Nullable Bitmap icon, int fallbackColor, boolean isFallbackColorDefault);

}

/**