chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java - Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home. (Closed)

Patch Set: Minor cleanups. Comments, order of members. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageViewHolder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

index 850fec8fcea53163452aeb9a6419d2761f49c167..2eea6f04416d1cfa7fa5b610d6c0149de37f8507 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

@@ -8,6 +8,7 @@ import org.chromium.base.Callback;

import org.chromium.base.Log;

import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;

import org.chromium.chrome.browser.ntp.NewTabPageUma;

+import org.chromium.chrome.browser.ntp.cards.NewTabPageViewHolder.PartialBindCallback;

import org.chromium.chrome.browser.ntp.snippets.CategoryInt;

import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;

import org.chromium.chrome.browser.ntp.snippets.SectionHeader;

@@ -19,7 +20,6 @@ import org.chromium.chrome.browser.ntp.snippets.SuggestionsSource;

import org.chromium.chrome.browser.offlinepages.ClientId;

import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;

import org.chromium.chrome.browser.offlinepages.OfflinePageItem;

-import org.chromium.chrome.browser.suggestions.PartialUpdateId;

import org.chromium.chrome.browser.suggestions.SuggestionsRanker;

import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;

@@ -206,7 +206,13 @@ public class SuggestionsSection extends InnerNode {

article.setOfflinePageOfflineId(newId);

if ((oldId == null) == (newId == null)) return;

- notifyItemChanged(index, PartialUpdateId.OFFLINE_BADGE);

+ notifyItemChanged(index, new PartialBindCallback() {

+ @Override

+ public void onResult(NewTabPageViewHolder holder) {

+ assert holder instanceof SnippetArticleViewHolder;

+ ((SnippetArticleViewHolder) holder).refreshOfflineBadgeVisibility();

+ }

+ });

}