chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java - Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2651673010: 🍝🏠 Refactor MostVisited UI management, extract it for reuse in Home. (Closed)

Patch Set: Minor cleanups. Comments, order of members. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ItemViewType.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/PartialUpdateId.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

index 9ba6879aae3ee2fe32f1e7929551dfeabef7cf79..b1fcf0f7c2c91a4d18a6d4200cb3a5defb65ffe1 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

@@ -311,6 +311,7 @@ public abstract class CardViewHolder

case ItemViewType.PROMO:

return true;

case ItemViewType.ABOVE_THE_FOLD:

+ case ItemViewType.TILE_GRID:

case ItemViewType.HEADER:

case ItemViewType.SPACING:

case ItemViewType.PROGRESS: