Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: net/quic/core/quic_session.cc

Issue 2651673004: Add quic_map_util. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_sent_packet_manager.cc ('k') | net/quic/core/quic_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_session.cc
diff --git a/net/quic/core/quic_session.cc b/net/quic/core/quic_session.cc
index 0845816fac4ffdedc2972bbd221c88166bc33be9..0f8040e5f95ab7c2cbd2ae0538ff7859b3494bb9 100644
--- a/net/quic/core/quic_session.cc
+++ b/net/quic/core/quic_session.cc
@@ -4,13 +4,13 @@
#include "net/quic/core/quic_session.h"
-#include "base/stl_util.h"
#include "net/quic/core/crypto/proof_verifier.h"
#include "net/quic/core/quic_connection.h"
#include "net/quic/core/quic_flags.h"
#include "net/quic/core/quic_flow_controller.h"
#include "net/quic/platform/api/quic_bug_tracker.h"
#include "net/quic/platform/api/quic_logging.h"
+#include "net/quic/platform/api/quic_map_util.h"
#include "net/quic/platform/api/quic_str_cat.h"
using base::StringPiece;
@@ -83,7 +83,7 @@ void QuicSession::OnStreamFrame(const QuicStreamFrame& frame) {
}
void QuicSession::OnRstStream(const QuicRstStreamFrame& frame) {
- if (base::ContainsKey(static_stream_map_, frame.stream_id)) {
+ if (QuicContainsKey(static_stream_map_, frame.stream_id)) {
connection()->CloseConnection(
QUIC_INVALID_STREAM_ID, "Attempt to reset a static stream",
ConnectionCloseBehavior::SEND_CONNECTION_CLOSE_PACKET);
@@ -311,7 +311,7 @@ QuicConsumedData QuicSession::WritevData(
void QuicSession::SendRstStream(QuicStreamId id,
QuicRstStreamErrorCode error,
QuicStreamOffset bytes_written) {
- if (base::ContainsKey(static_stream_map_, id)) {
+ if (QuicContainsKey(static_stream_map_, id)) {
QUIC_BUG << "Cannot send RST for a static stream with ID " << id;
return;
}
@@ -624,8 +624,8 @@ void QuicSession::ActivateStream(std::unique_ptr<QuicStream> stream) {
QuicStreamId stream_id = stream->id();
QUIC_DLOG(INFO) << ENDPOINT << "num_streams: " << dynamic_stream_map_.size()
<< ". activating " << stream_id;
- DCHECK(!base::ContainsKey(dynamic_stream_map_, stream_id));
- DCHECK(!base::ContainsKey(static_stream_map_, stream_id));
+ DCHECK(!QuicContainsKey(dynamic_stream_map_, stream_id));
+ DCHECK(!QuicContainsKey(static_stream_map_, stream_id));
dynamic_stream_map_[stream_id] = std::move(stream);
if (IsIncomingStream(stream_id)) {
++num_dynamic_incoming_streams_;
@@ -649,8 +649,8 @@ QuicStream* QuicSession::GetOrCreateStream(const QuicStreamId stream_id) {
}
void QuicSession::StreamDraining(QuicStreamId stream_id) {
- DCHECK(base::ContainsKey(dynamic_stream_map_, stream_id));
- if (!base::ContainsKey(draining_streams_, stream_id)) {
+ DCHECK(QuicContainsKey(dynamic_stream_map_, stream_id));
+ if (!QuicContainsKey(draining_streams_, stream_id)) {
draining_streams_.insert(stream_id);
if (IsIncomingStream(stream_id)) {
++num_draining_incoming_streams_;
@@ -703,7 +703,7 @@ bool QuicSession::ShouldYield(QuicStreamId stream_id) {
QuicStream* QuicSession::GetOrCreateDynamicStream(
const QuicStreamId stream_id) {
- DCHECK(!base::ContainsKey(static_stream_map_, stream_id))
+ DCHECK(!QuicContainsKey(static_stream_map_, stream_id))
<< "Attempt to call GetOrCreateDynamicStream for a static stream";
DynamicStreamMap::iterator it = dynamic_stream_map_.find(stream_id);
@@ -772,13 +772,13 @@ bool QuicSession::IsClosedStream(QuicStreamId id) {
}
// For peer created streams, we also need to consider available streams.
return id <= largest_peer_created_stream_id_ &&
- !base::ContainsKey(available_streams_, id);
+ !QuicContainsKey(available_streams_, id);
}
bool QuicSession::IsOpenStream(QuicStreamId id) {
DCHECK_NE(0u, id);
- if (base::ContainsKey(static_stream_map_, id) ||
- base::ContainsKey(dynamic_stream_map_, id)) {
+ if (QuicContainsKey(static_stream_map_, id) ||
+ QuicContainsKey(dynamic_stream_map_, id)) {
// Stream is active
return true;
}
« no previous file with comments | « net/quic/core/quic_sent_packet_manager.cc ('k') | net/quic/core/quic_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698