Show human readable origin for Android apps

third_party/closure_compiler/externs/passwords_private.js

Index: third_party/closure_compiler/externs/passwords_private.js
diff --git a/third_party/closure_compiler/externs/passwords_private.js b/third_party/closure_compiler/externs/passwords_private.js
index b53aa2643b66abb61ef6e9c82af94fd623a21696..61c405adaefca07762855a850b5966922b244638 100644
--- a/third_party/closure_compiler/externs/passwords_private.js
+++ b/third_party/closure_compiler/externs/passwords_private.js
@@ -41,9 +41,9 @@ chrome.passwordsPrivate.PasswordUiEntry;
  *   exceptionUrl: string,
  *   linkUrl: string
  * }}
- * @see https://developer.chrome.com/extensions/passwordsPrivate#type-ExceptionPair
+ * @see https://developer.chrome.com/extensions/passwordsPrivate#type-ExceptionEntry
  */
-chrome.passwordsPrivate.ExceptionPair;
+chrome.passwordsPrivate.ExceptionEntry;

[jdoerrie, 2017/04/21 17:07:18]

Modifying this manually is definitely the wrong way to go, but I didn't manage
to find out what script exactly I need to run to generate this.
tools/json_schema_compiler/compiler.py did not do the trick for me. Any
insights?

[tommycli, 2017/04/21 17:18:49]

Check dis out:
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/passwords_p...

Running a normal build should regenerate the auto-generated cpp files too.

[hcarmona, 2017/04/21 17:52:19]

Doesn't seem to regen on my machine automatically.
IIRCC there's a script we need to run, but i don't remember where it is :-\ I'm
looking for it and will update when I find it

[hcarmona, 2017/04/21 18:04:19]

go/ndgmw worked for me :-)

 
 /**
  * @typedef {{
@@ -94,7 +94,7 @@ chrome.passwordsPrivate.getSavedPasswordList = function(callback) {};
 
 /**
  * Returns the list of password exceptions.
- * @param {function(!Array<!chrome.passwordsPrivate.ExceptionPair>):void}
+ * @param {function(!Array<!chrome.passwordsPrivate.ExceptionEntry>):void}
  *     callback Called with the list of password exceptions.
  * @see https://developer.chrome.com/extensions/passwordsPrivate#method-getPasswordExceptionList
  */