Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5125)

Unified Diff: chrome/common/extensions/api/passwords_private.idl

Issue 2651663003: Show human readable origin for Android apps (Closed)
Patch Set: Fix tests and nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/passwords_private.idl
diff --git a/chrome/common/extensions/api/passwords_private.idl b/chrome/common/extensions/api/passwords_private.idl
index 58e03e5fcbaee6e02175367f224c411822d82dbd..4784122869977e03bec03a0a45b82e33a457f529 100644
--- a/chrome/common/extensions/api/passwords_private.idl
+++ b/chrome/common/extensions/api/passwords_private.idl
@@ -5,10 +5,20 @@
// Use the <code>chrome.passwordsPrivate</code> API to add or remove password
// data from the settings UI.
namespace passwordsPrivate {
- // Pair of origin URL and login saved for that URL.
+ dictionary UrlCollection {
+ // The fully specified URL of the credential's origin.
+ DOMString origin;
+
+ // A human readable version of the URL of the credential's origin.
+ DOMString shown;
+
+ // The URL that will be linked to when an entry is clicked.
+ DOMString link;
+ };
+
+ // Pair of a URL collection and a username saved for these URLs.
dictionary LoginPair {
- // The human-readable origin for the URL where the password is used.
- DOMString originUrl;
+ UrlCollection urls;
// The username used in conjunction with the saved password.
DOMString username;
@@ -19,9 +29,6 @@ namespace passwordsPrivate {
// The login information for this entry.
LoginPair loginPair;
- // The complete URL of the page that the password is saved for.
- DOMString linkUrl;
-
// The number of characters in the password; used to display placeholder
// dots in the UI.
long numCharactersInPassword;
@@ -30,14 +37,6 @@ namespace passwordsPrivate {
DOMString? federationText;
};
- dictionary ExceptionPair {
- // The human-readable URL where passwords will not be saved.
- DOMString exceptionUrl;
-
- // The complete URL of the page that the exception was created for.
- DOMString linkUrl;
- };
-
// Dictionary passed to listeners for the onPlaintextPasswordRetrieved event.
dictionary PlaintextPasswordEventParameters {
// The LoginPair associated with the retrieved password.
@@ -47,8 +46,12 @@ namespace passwordsPrivate {
DOMString plaintextPassword;
};
+ dictionary ExceptionEntry {
+ UrlCollection urls;
+ };
+
callback PasswordListCallback = void(PasswordUiEntry[] entries);
- callback ExceptionListCallback = void(ExceptionPair[] exceptions);
+ callback ExceptionListCallback = void(ExceptionEntry[] exceptions);
interface Functions {
// Removes the saved password corresponding to |loginPair|. If no saved
@@ -93,7 +96,7 @@ namespace passwordsPrivate {
// entry has been added or removed.
//
// |exceptions|: The updated list of password exceptions.
- static void onPasswordExceptionsListChanged(ExceptionPair[] exceptions);
+ static void onPasswordExceptionsListChanged(ExceptionEntry[] exceptions);
// Fired when a plaintext password has been fetched in response to a call to
// chrome.passwordsPrivate.requestPlaintextPassword().

Powered by Google App Engine
This is Rietveld 408576698