Show human readable origin for Android apps

third_party/closure_compiler/externs/passwords_private.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file was generated by:
 //   tools/json_schema_compiler/compiler.py.
 // NOTE: The format of types has changed. 'FooType' is now
 //   'chrome.passwordsPrivate.FooType'.
 // Please run the closure compiler before committing changes.
 // See https://chromium.googlesource.com/chromium/src/+/master/docs/closure_compilation.md
@@ skipping 23 matching lines @@
  * }}
  * @see https://developer.chrome.com/extensions/passwordsPrivate#type-PasswordUiEntry
  */
 chrome.passwordsPrivate.PasswordUiEntry;
 
 /**
  * @typedef {{
  *   exceptionUrl: string,
  *   linkUrl: string
  * }}
- * @see https://developer.chrome.com/extensions/passwordsPrivate#type-ExceptionPair
+ * @see https://developer.chrome.com/extensions/passwordsPrivate#type-ExceptionEntry
  */
-chrome.passwordsPrivate.ExceptionPair;
+chrome.passwordsPrivate.ExceptionEntry;

[jdoerrie, 2017/04/21 17:07:18]

Modifying this manually is definitely the wrong way to go, but I didn't manage
to find out what script exactly I need to run to generate this.
tools/json_schema_compiler/compiler.py did not do the trick for me. Any
insights?

[tommycli, 2017/04/21 17:18:49]

Check dis out:
https://cs.chromium.org/chromium/src/chrome/common/extensions/api/passwords_p...

Running a normal build should regenerate the auto-generated cpp files too.

[hcarmona, 2017/04/21 17:52:19]

Doesn't seem to regen on my machine automatically.
IIRCC there's a script we need to run, but i don't remember where it is :-\ I'm
looking for it and will update when I find it

[hcarmona, 2017/04/21 18:04:19]

go/ndgmw worked for me :-)

 
 /**
  * @typedef {{
  *   loginPair: !chrome.passwordsPrivate.LoginPair,
  *   plaintextPassword: string
  * }}
  * @see https://developer.chrome.com/extensions/passwordsPrivate#type-PlaintextPasswordEventParameters
  */
 chrome.passwordsPrivate.PlaintextPasswordEventParameters;
 
@@ skipping 30 matching lines @@
 /**
  * Returns the list of saved passwords.
  * @param {function(!Array<!chrome.passwordsPrivate.PasswordUiEntry>):void}
  *     callback Called with the list of saved passwords.
  * @see https://developer.chrome.com/extensions/passwordsPrivate#method-getSavedPasswordList
  */
 chrome.passwordsPrivate.getSavedPasswordList = function(callback) {};
 
 /**
  * Returns the list of password exceptions.
- * @param {function(!Array<!chrome.passwordsPrivate.ExceptionPair>):void}
+ * @param {function(!Array<!chrome.passwordsPrivate.ExceptionEntry>):void}
  *     callback Called with the list of password exceptions.
  * @see https://developer.chrome.com/extensions/passwordsPrivate#method-getPasswordExceptionList
  */
 chrome.passwordsPrivate.getPasswordExceptionList = function(callback) {};
 
 /**
  * Fired when the saved passwords list has changed, meaning that an entry has
  * been added or removed.
  * @type {!ChromeEvent}
  * @see https://developer.chrome.com/extensions/passwordsPrivate#event-onSavedPasswordsListChanged
  */
 chrome.passwordsPrivate.onSavedPasswordsListChanged;
 
 /**
  * Fired when the password exceptions list has changed, meaning that an entry
  * has been added or removed.
  * @type {!ChromeEvent}
  * @see https://developer.chrome.com/extensions/passwordsPrivate#event-onPasswordExceptionsListChanged
  */
 chrome.passwordsPrivate.onPasswordExceptionsListChanged;
 
 /**
  * Fired when a plaintext password has been fetched in response to a call to
  * chrome.passwordsPrivate.requestPlaintextPassword().
  * @type {!ChromeEvent}
  * @see https://developer.chrome.com/extensions/passwordsPrivate#event-onPlaintextPasswordRetrieved
  */
 chrome.passwordsPrivate.onPlaintextPasswordRetrieved;