Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2651653006: Make Future.value() constructor in MockSdk consistent with the actual SDK. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Future.value() constructor in MockSdk consistent with the actual SDK. R=brianwilkerson@google.com, jmesserly@google.com, leafp@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/320fff61d485c4adc4406eb7ea12467aa2bc2f85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M pkg/analyzer/test/src/context/mock_sdk.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 10 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-24 17:36:24 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-24 17:44:35 UTC) #2
scheglov
3 years, 11 months ago (2017-01-24 20:34:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
320fff61d485c4adc4406eb7ea12467aa2bc2f85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698