Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: src/compiler/bytecode-analysis.cc

Issue 2651653005: [turbofan] Fix accumulator use in bytecode analysis. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-683581.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-analysis.cc
diff --git a/src/compiler/bytecode-analysis.cc b/src/compiler/bytecode-analysis.cc
index f0e870739b62d7b271907a7bdca8cfb1613d7989..6d8afe1744572bc015d6ee530cfcec03f65cef9a 100644
--- a/src/compiler/bytecode-analysis.cc
+++ b/src/compiler/bytecode-analysis.cc
@@ -98,9 +98,8 @@ void UpdateInLiveness(Bytecode bytecode, BytecodeLivenessState& in_liveness,
const BytecodeArrayAccessor& accessor) {
int num_operands = Bytecodes::NumberOfOperands(bytecode);
const OperandType* operand_types = Bytecodes::GetOperandTypes(bytecode);
- AccumulatorUse accumulator_use = Bytecodes::GetAccumulatorUse(bytecode);
- if (accumulator_use == AccumulatorUse::kWrite) {
+ if (Bytecodes::WritesAccumulator(bytecode)) {
in_liveness.MarkAccumulatorDead();
}
for (int i = 0; i < num_operands; ++i) {
@@ -138,7 +137,7 @@ void UpdateInLiveness(Bytecode bytecode, BytecodeLivenessState& in_liveness,
}
}
- if (accumulator_use == AccumulatorUse::kRead) {
+ if (Bytecodes::ReadsAccumulator(bytecode)) {
Leszek Swirski 2017/01/24 19:58:23 This is probably better for readability's sake, bu
in_liveness.MarkAccumulatorLive();
}
for (int i = 0; i < num_operands; ++i) {
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-683581.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698