Revert 268248 "NaCl: Update revision in DEPS, r13115 -> r13137"

Revert 268248 "NaCl: Update revision in DEPS, r13115 -> r13137"

> NaCl: Update revision in DEPS, r13115 -> r13137
> 
> This pulls in the following Native Client changes:
> 
> r13117: (mseaborn) Add a Scons-to-Ninja converter for getting faster incremental rebuilds
> r13118: (mseaborn) Scons: Remove unnecessary use of addRepository() for gtest
> r13119: (sbc) Add latest filename interface to IRT and sel_ldr.
> r13120: (jvoung) Remove some leftover bits of CloseManifestEntry and Log.
> r13121: (jfb) PNaCl SIMD: add test for vector cast and conversion
> r13122: (bradnelson) Reduce perf dashboard noise by excluding -dbg builders.
> r13123: (dyen) Added arguments to NaCl scons to allow custom toolchain directories.
> r13124: (mseaborn) scons_to_ninja: Fix Install() step to coexist with NaCl/SCons's version
> r13125: (dschuff) Test pinned PNaCl toolchain and gold plugin on mac and win toolchain bots
> r13126: (jfb) LLVM biased sandbox build: fix PNaCl driver script so it knows about more architectures
> r13127: (dyen) Fix bionic package_version archives.
> r13128: (dyen) Updated nacl_arm_bionic revision to r13127
> r13129: (dschuff) Switch PNaCl toolchain package info upload back to toolchain_build_pnacl
> r13130: (dyen) Added a way to specify packages with missing archives in package_version.
> r13131: (mseaborn) PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py
> r13132: (mseaborn) Non-SFI Mode: Add nonsfi_loader and plumbing to test it
> r13133: (mseaborn) Fix checkdeps.py failure on src/nonsfi/ produced by r13132
> r13134: (noelallen) Fix double crtbegin.o, extra gcc build steps on skip
> r13135: (dschuff) Update PNaCl pinned revision to 13129 and switch to toolchain_build_pnacl
> r13136: (bradnelson) Add NACL_GOMA_THREADS in build_nexe.py to limit number of threads (for sergeyu)
> r13137: (noelallen) Add scons to gn script
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> R=bradnelson@google.com
> 
> Review URL: https://codereview.chromium.org/266163002

TBR=mseaborn@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268255

[miu, 2014-05-05 20:14:58]

FYI--Failed on Win x64 build:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Buil...

From the logs:

[481/1544] STAMP
obj\native_client\src\shared\gio\gio_lib.actions_rules_copies.stamp
FAILED: C:\b\depot_tools\python276_bin\python.exe gyp-win-tool action-wrapper
environment.x64
pnacl_irt_shim_aot_target_build_newlib_x86_32_nonsfi_nlib__via_pnacl__34170b6937a459767c91fc53e218266c..rsp
..\..\ppapi\native_client\src\untrusted\pnacl_irt_shim
error: error opening
'../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim_aot.gen/pnacl_newlib_x86_32-nonsfi/pnacl_irt_shim_aot/irt_shim_ppapi.o.d':
Error opening output file
'../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim_aot.gen/pnacl_newlib_x86_32-nonsfi/pnacl_irt_shim_aot/irt_shim_ppapi.o.d':
The system cannot find the path specified
1 error generated.
..\..\..\..\..\out\Release_x64\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang -c
irt_shim_ppapi.c -o
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim_aot.gen/pnacl_newlib_x86_32-nonsfi/pnacl_irt_shim_aot/irt_shim_ppapi.o
-MD -MF
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim_aot.gen/pnacl_newlib_x86_32-nonsfi/pnacl_irt_shim_aot/irt_shim_ppapi.o.d
-std=gnu99 --target=i686-unknown-nacl --pnacl-allow-native
--pnacl-allow-translate -arch x86-32-nonsfi -O2 -g -Wall
-fdiagnostics-show-option -Werror -DPNACL_SHIM_AOT -Wno-unused-function
-Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args
-Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts
-Wno-unused-function -D__linux__ -D__STDC_LIMIT_MACROS=1
-D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_BSD_SOURCE=1
-D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86
-DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DNOMINMAX
-DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS
-D_ATL_NO_OPENGL -D_SECURE_ATL -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUSE_AURA=1
-DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
-DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DNO_TCMALLOC -DENABLE_EGLIMAGE=1
-D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE
-DNTDDI_VERSION=0x06020000 -D_USING_V110_SDK71_ -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2
-DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DNACL_WINDOWS=0
-DNACL_OSX=0 -DNACL_LINUX=0
-I../../../../../out/Release_x64/gen/tc_pnacl_newlib/include -I../../../../..
-I../../../../../third_party/wtl/include

FAILED: Command
'..\..\..\..\..\out\Release_x64\gen\sdk\win_x86\pnacl_newlib\bin\pnacl-clang -c
irt_shim_ppapi.c -o
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim_aot.gen/pnacl_newlib_x86_32-nonsfi/pnacl_irt_shim_aot/irt_shim_ppapi.o
-MD -MF
../../../../../out/Release_x64/obj/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim_aot.gen/pnacl_newlib_x86_32-nonsfi/pnacl_irt_shim_aot/irt_shim_ppapi.o.d
-std=gnu99 --target=i686-unknown-nacl --pnacl-allow-native
--pnacl-allow-translate -arch x86-32-nonsfi -O2 -g -Wall
-fdiagnostics-show-option -Werror -DPNACL_SHIM_AOT -Wno-unused-function
-Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args
-Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts
-Wno-unused-function -D__linux__ -D__STDC_LIMIT_MACROS=1
-D__STDC_FORMAT_MACROS=1 -D_GNU_SOURCE=1 -D_BSD_SOURCE=1
-D_POSIX_C_SOURCE=199506 -D_XOPEN_SOURCE=600 -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DDYNAMIC_ANNOTATIONS_PREFIX=NACL_ -DNACL_BUILD_ARCH=x86
-DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DNOMINMAX
-DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS
-D_ATL_NO_OPENGL -D_SECURE_ATL -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUSE_AURA=1
-DUSE_ASH=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
-DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DNO_TCMALLOC -DENABLE_EGLIMAGE=1
-D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE
-DNTDDI_VERSION=0x06020000 -D_USING_V110_SDK71_ -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2
-DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DNACL_WINDOWS=0
-DNACL_OSX=0 -DNACL_LINUX=0
-I../../../../../out/Release_x64/gen/tc_pnacl_newlib/include -I../../../../..
-I../../../../../third_party/wtl/include' returned non-zero exit status 1

ninja: build stopped: subcommand failed.

[miu, 2014-05-05 20:15:06]

Committed patchset #1 manually as r268255 (tree was closed).

[Mark Seaborn, 2014-05-05 20:52:15]

LGTM

This is apparently a Windows problem with filename lengths.

This was caused by:
r13129: (dschuff) Switch PNaCl toolchain package info upload back to
toolchain_build_pnacl
which switches from a Cygwin build of the LLVM toolchain to a MinGW build.

Cygwin works around the Windows filename length limitation, whereas Clang/LLVM
built with MinGW uses the Windows APIs directly and doesn't work around the
limitation.

Whereas the x64 trybot uses:
  E:\b\build\slave\win\build\src\out\Release_x64
the x64 buildbot uses:
  C:\b\build\slave\cr-win-rel-x64\build\src\out\Release_x64

It looks like that extra length makes the build exceed the filename length
limit.

[Derek Schuff, 2014-05-05 22:09:43]

On 2014/05/05 20:52:15, Mark Seaborn wrote:
> LGTM
> 
> This is apparently a Windows problem with filename lengths.
> 
> This was caused by:
> r13129: (dschuff) Switch PNaCl toolchain package info upload back to
> toolchain_build_pnacl
> which switches from a Cygwin build of the LLVM toolchain to a MinGW build.
> 
> Cygwin works around the Windows filename length limitation, whereas Clang/LLVM
> built with MinGW uses the Windows APIs directly and doesn't work around the
> limitation.
> 
> Whereas the x64 trybot uses:
>   E:\b\build\slave\win\build\src\out\Release_x64
> the x64 buildbot uses:
>   C:\b\build\slave\cr-win-rel-x64\build\src\out\Release_x64
> 
> It looks like that extra length makes the build exceed the filename length
> limit.

https://codereview.chromium.org/263083012/ has landed, so we can try the DEPS
roll again.