Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7134)

Unified Diff: chrome/common/mac/app_mode_chrome_locator_unittest.mm

Issue 265163006: [Mac] Rebuild app shims when they fail to dyload Chrome Framework. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Change to official release shim. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/mac/app_mode_chrome_locator_unittest.mm
diff --git a/chrome/common/mac/app_mode_chrome_locator_unittest.mm b/chrome/common/mac/app_mode_chrome_locator_unittest.mm
index 50e98bfce8c2aa7163b5ea57874c1b20ef4be46d..ecaed7d513aee3adf1b94c1ae58e20942acc707c 100644
--- a/chrome/common/mac/app_mode_chrome_locator_unittest.mm
+++ b/chrome/common/mac/app_mode_chrome_locator_unittest.mm
@@ -43,11 +43,12 @@ TEST(ChromeLocatorTest, GetNonExistentBundleInfo) {
base::ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
+ base::FilePath executable_path;
base::string16 raw_version;
base::FilePath version_path;
base::FilePath framework_path;
EXPECT_FALSE(app_mode::GetChromeBundleInfo(temp_dir.path(),
- &raw_version, &version_path, &framework_path));
+ &executable_path, &raw_version, &version_path, &framework_path));
}
TEST(ChromeLocatorTest, GetChromeBundleInfo) {
@@ -57,11 +58,13 @@ TEST(ChromeLocatorTest, GetChromeBundleInfo) {
GetChromeBundlePath(&chrome_bundle_path);
ASSERT_TRUE(base::DirectoryExists(chrome_bundle_path));
+ base::FilePath executable_path;
base::string16 raw_version;
base::FilePath version_path;
base::FilePath framework_path;
EXPECT_TRUE(GetChromeBundleInfo(chrome_bundle_path,
- &raw_version, &version_path, &framework_path));
+ &executable_path, &raw_version, &version_path, &framework_path));
+ EXPECT_TRUE(base::PathExists(executable_path));
EXPECT_GT(raw_version.size(), 0U);
EXPECT_TRUE(base::DirectoryExists(version_path));
EXPECT_TRUE(base::PathExists(framework_path));

Powered by Google App Engine
This is Rietveld 408576698