Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 265163004: NaCl documentation: update vector documentation (Closed)

Created:
6 years, 7 months ago by JF
Modified:
6 years, 7 months ago
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Visibility:
Public.

Description

NaCl documentation: update vector documentation Explain shuffle vector. Note that the text shouldn't be contended since it's the same as LLVM's own documentation: http://clang.llvm.org/docs/LanguageExtensions.html#langext-builtin-shufflevector Also update the bitcode ABI document to mention vector types and {insert/extract}element. TBR= nfullagar@chromium.org, dschuff@chromium.org, kschimpf@chromium.org TEST= none BUG= https://code.google.com/p/nativeclient/issues/detail?id=2205 NOTRY=true (documentation only change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268609

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clarify vector width. #

Total comments: 2

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -20 lines) Patch
M native_client_sdk/doc_generated/reference/pnacl-bitcode-abi.html View 1 3 chunks +29 lines, -16 lines 0 comments Download
M native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html View 1 2 2 chunks +35 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst View 1 2 chunks +13 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst View 1 2 2 chunks +37 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
JF
6 years, 7 months ago (2014-05-04 21:03:21 UTC) #1
JF
The CQ bit was checked by jfb@chromium.org
6 years, 7 months ago (2014-05-04 21:03:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/265163004/1
6 years, 7 months ago (2014-05-04 21:03:53 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-04 21:03:54 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-04 21:03:55 UTC) #5
Karl
https://codereview.chromium.org/265163004/diff/1/native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst File native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst (right): https://codereview.chromium.org/265163004/diff/1/native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst#newcode207 native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst:207: previously (their width is therefore not 128-bits). Isn't this ...
6 years, 7 months ago (2014-05-05 19:49:39 UTC) #6
JF
https://codereview.chromium.org/265163004/diff/1/native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst File native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst (right): https://codereview.chromium.org/265163004/diff/1/native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst#newcode207 native_client_sdk/src/doc/reference/pnacl-bitcode-abi.rst:207: previously (their width is therefore not 128-bits). On 2014/05/05 ...
6 years, 7 months ago (2014-05-05 23:12:49 UTC) #7
Derek Schuff
lgtm https://codereview.chromium.org/265163004/diff/20001/native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst File native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst (right): https://codereview.chromium.org/265163004/diff/20001/native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst#newcode320 native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst:320: constant integers that specify the elements indices of ...
6 years, 7 months ago (2014-05-06 17:29:50 UTC) #8
Karl
lgtm
6 years, 7 months ago (2014-05-06 20:33:13 UTC) #9
JF
https://codereview.chromium.org/265163004/diff/20001/native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst File native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst (right): https://codereview.chromium.org/265163004/diff/20001/native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst#newcode320 native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst:320: constant integers that specify the elements indices of the ...
6 years, 7 months ago (2014-05-06 21:11:02 UTC) #10
JF
The CQ bit was checked by jfb@chromium.org
6 years, 7 months ago (2014-05-06 21:11:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jfb@chromium.org/265163004/40001
6 years, 7 months ago (2014-05-06 21:13:43 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 21:16:40 UTC) #13
Message was sent while issue was closed.
Change committed as 268609

Powered by Google App Engine
This is Rietveld 408576698