Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: tools/perf/page_sets/system_health/system_health_story.py

Issue 2651623005: [tools/perf] Create a list of tags for system_health_story (Closed)
Patch Set: Address review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/system_health/story_tags.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/system_health/system_health_story.py
diff --git a/tools/perf/page_sets/system_health/system_health_story.py b/tools/perf/page_sets/system_health/system_health_story.py
index 78b9347b73e0787a72ea31f5d76a5c6da5243b1c..7104f40c18308ffef1c93274ec887e97ea175582 100644
--- a/tools/perf/page_sets/system_health/system_health_story.py
+++ b/tools/perf/page_sets/system_health/system_health_story.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
from page_sets.system_health import platforms
+from page_sets.system_health import story_tags
from telemetry import decorators
from telemetry.page import page
@@ -65,12 +66,18 @@ class SystemHealthStory(page.Page):
URL = NotImplemented
ABSTRACT_STORY = True
SUPPORTED_PLATFORMS = platforms.ALL_PLATFORMS
+ TAGS = None
def __init__(self, story_set, take_memory_measurement):
case, group, _ = self.NAME.split(':')
+ tags = []
+ if self.TAGS:
+ for t in self.TAGS:
+ assert t in story_tags.ALL_TAGS
+ tags.append(t.name)
super(SystemHealthStory, self).__init__(
shared_page_state_class=_SystemHealthSharedState, page_set=story_set,
- name=self.NAME, url=self.URL,
+ name=self.NAME, url=self.URL, tags=tags,
credentials_path='../data/credentials.json',
grouping_keys={'case': case, 'group': group})
self._take_memory_measurement = take_memory_measurement
« no previous file with comments | « tools/perf/page_sets/system_health/story_tags.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698