[tools/perf] Create a list of tags for system_health_story

tools/perf/page_sets/system_health/system_health_tags.py

Index: tools/perf/page_sets/system_health/system_health_tags.py
diff --git a/tools/perf/page_sets/system_health/system_health_tags.py b/tools/perf/page_sets/system_health/system_health_tags.py
new file mode 100644
index 0000000000000000000000000000000000000000..00bdc16605338be5df5f9489b98023bb8c2609c6
--- /dev/null
+++ b/tools/perf/page_sets/system_health/system_health_tags.py
@@ -0,0 +1,68 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.

[nednguyen, 2017/01/24 17:59:01]

Note that I have name this "system_health_tags" instead of just "tags" to avoid
naming collision with the tags variable. 

[rnephew (Reviews Here), 2017/01/24 18:23:09]

If this plans to go farther than system health benchmarks maybe benchmark_tags
would be better?

[charliea (OOO until 10-5), 2017/01/24 23:00:05]

My vote for the name is story_tags because:

  - system_health.system_health_tags is redundant
  - system_health.benchmark_tags indicates that the tags apply to the
benchmarks, but they actually apply to the stories

[nednguyen, 2017/02/03 15:02:42]

Done.

+
+import sys
+
+
+class TagInfo(object):
+  def __init__(self, tag, description):
+    self._tag = tag
+    self._description = description
+
+  @property
+  def tag(self):
+    return self._tag
+
+  @property
+  def description(self):
+    return self._description
+
+AUDIO_PLAYING = TagInfo(
+    'audio-playing', 'Stories with this tag have audio playing')

[perezju, 2017/01/24 19:50:05]

"Stories with this tag have .." an all descriptions is a bit repetitive and
doesn't add much info.

Maybe: "Story plays audio", "Story has html5 canvas animations", "Story has CSS
animations", etc.? Also make them full sentences (i.e. start uppercase and end
with a full stop.)

[charliea (OOO until 10-5), 2017/01/24 23:00:05]

It seems like we should be consistent about what's in a tag name: if we have
"audio playing" (present participle), then it should be "canvas-animating"
(present participle) instead of "canvas animation" (noun).

My vote is for all nouns:

audio, canvas-animation, css-animation, pinch-zoom, images, multi-tabs,
international, scroll, pinch-zoom, multi-tabs, video, webgl, web-storage

only changes required are:

audio-playing =>audio, video-playing=>video

[perezju, 2017/01/25 00:06:45]

+1 to all nouns, and document this fact on the file.

I would suggest, though: audio-playback, video-playback

[nednguyen, 2017/02/03 15:02:42]

Done.

+CANVAS_ANIMATION = TagInfo(
+    'canvas-animation', 'stories with this tags have animations that are '

[rnephew (Reviews Here), 2017/01/24 18:23:09]

Nit:Inconsistent capitalization between tags.

[nednguyen, 2017/02/03 15:02:42]

Done.

+    'implemented using html5 canvas')
+CSS_ANIMATION = TagInfo(
+    'css-animation', 'stories with this tags have animations that are '
+    'implemented using CSS')
+EXTENSION = TagInfo(
+    'pinch-zoom', 'stories with this tags have browser with extension '
+    'installed')
+IMAGES = TagInfo(
+    'web-storage', 'stories with this tags have sites with heavy uses of '

[charliea (OOO until 10-5), 2017/01/24 23:00:05]

wut? web-storage == images?

[nednguyen, 2017/02/03 15:02:42]

Done.

+    'images.')
+INTERNATIONAL = TagInfo(
+    'multi-tabs', 'stories with this tags include navigating to websites '

[charliea (OOO until 10-5), 2017/01/24 23:00:05]

same

[nednguyen, 2017/02/03 15:02:42]

Done.

+    'in non English speaking countries.')
+SCROLL = TagInfo(
+    'scroll', 'stories with this tags have scroll gestures & scroll '
+    'animation')
+PINCH_ZOOM = TagInfo(
+    'pinch-zoom', 'stories with this tags have pinch zoom gestures & pinch zoom'
+    ' animation')
+MULTI_TABS_SWITCHING = TagInfo(
+    'multi-tabs', 'stories with this tags have multi tabs and tabs switching '
+    'action')
+VIDEO_PLAYING = TagInfo(
+    'video-playing', 'Stories with this tag have video playing')
+WEBGL = TagInfo(
+    'webgl', 'stories with this tags have sites with heavy uses of WebGL.')
+WEB_STORAGE = TagInfo(
+    'web-storage', 'stories with this tags have sites with heavy uses of Web '
+    'storage.')
+
+
+def _ExtractAllTagInfos():
+  all_tags = set()
+  all_tags_info = []
+  for obj in dir(sys.modules[__name__]):

[rnephew (Reviews Here), 2017/01/24 18:23:09]

A comment on what this is actually doing would be nice, wasn't immediately
obvious.

[charliea (OOO until 10-5), 2017/01/24 23:00:05]

+1

[nednguyen, 2017/02/03 15:02:42]

Done.

+    if isinstance(obj, TagInfo):
+      all_tags_info.append(obj)
+      assert obj.tag not in all_tags, 'Duplicate tag: %s' % obj.tag
+      all_tags.add(obj.tag)
+  return all_tags_info
+
+
+ALL_TAG_INFOS = _ExtractAllTagInfos()
+ALL_TAGS = [t.tag for t in ALL_TAG_INFOS]