Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2651613003: Added support for GN workspaces. (Closed)

Created:
3 years, 11 months ago by P.Y.L.
Modified:
3 years, 11 months ago
Reviewers:
abarth, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -0 lines) Patch
M pkg/analyzer/lib/src/context/builder.dart View 2 chunks +12 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/generated/gn.dart View 1 chunk +255 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/gn_test.dart View 1 1 chunk +132 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
P.Y.L.
3 years, 11 months ago (2017-01-23 22:00:07 UTC) #3
Brian Wilkerson
Please consider adding some tests, similar to those in 'analyzer/test/generated/bazel_test.dart'. Other than that, lgtm.
3 years, 11 months ago (2017-01-23 22:31:45 UTC) #4
P.Y.L.
On 2017/01/23 22:31:45, Brian Wilkerson wrote: > Please consider adding some tests, similar to those ...
3 years, 11 months ago (2017-01-23 22:37:10 UTC) #5
P.Y.L.
On 2017/01/23 22:37:10, P.Y.L. wrote: > On 2017/01/23 22:31:45, Brian Wilkerson wrote: > > Please ...
3 years, 11 months ago (2017-01-24 00:18:00 UTC) #6
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-24 01:32:17 UTC) #7
P.Y.L.
On 2017/01/24 01:32:17, Brian Wilkerson wrote: > lgtm Could you grant me commit access to ...
3 years, 11 months ago (2017-01-24 18:33:47 UTC) #8
P.Y.L.
Committed patchset #2 (id:20001) manually as 66cda63fea10ce7456cf9d9e0bd8c2cb14551b7d (presubmit successful).
3 years, 11 months ago (2017-01-25 17:26:52 UTC) #10
Bill Hesse
3 years, 11 months ago (2017-01-25 20:58:08 UTC) #11
Message was sent while issue was closed. 
On 2017/01/25 17:26:52, P.Y.L. wrote:
> Committed patchset #2 (id:20001) manually as
> 66cda63fea10ce7456cf9d9e0bd8c2cb14551b7d (presubmit successful).

This new test is failing on Windows.  It was masked on the buildbot by other
tests failing on windows at the same time.  Here is the error:

Expected: 'C:\\workspace\\a\\source\\code.dart'
    Actual: '/workspace/a/source\\code.dart'

Powered by Google App Engine
This is Rietveld 408576698