Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4919)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java

Issue 2651553005: Remove ListUrlsActivity (Closed)
Patch Set: Removing ListUrlsActivity Tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
index f856fcb44101c9336a617667aeb76042e3045911..354765be5e359ccf8dc56410177c6161ab2b8ade 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
@@ -26,6 +26,11 @@ import javax.annotation.concurrent.ThreadSafe;
*/
@ThreadSafe
public class PhysicalWebUma {
+ // Obsolete; don't use: NOTIFICATION_REFERER = 1;
+ // Obsolete; don't use: OPTIN_REFERER = 2;
+ public static final int PREFERENCE_REFERER = 3;
+ public static final int DIAGNOSTICS_REFERER = 4;
+
private static final String TAG = "PhysicalWeb";
private static final String HAS_DEFERRED_METRICS_KEY = "PhysicalWeb.HasDeferredMetrics";
private static final String OPT_IN_DECLINE_BUTTON_PRESS_COUNT =
@@ -55,6 +60,7 @@ public class PhysicalWebUma {
private static final String PREFERENCE = "Preference";
private static final int BOOLEAN_BOUNDARY = 2;
private static final int TRISTATE_BOUNDARY = 3;
+ private static final int REFERER_BOUNDARY = 5;
/**
* Records a URL selection.
@@ -163,12 +169,12 @@ public class PhysicalWebUma {
* histograms.xml.
*/
public static void onActivityReferral(int referer) {
- handleEnum(ACTIVITY_REFERRALS, referer, ListUrlsActivity.REFERER_BOUNDARY);
+ handleEnum(ACTIVITY_REFERRALS, referer, REFERER_BOUNDARY);
switch (referer) {
- case ListUrlsActivity.PREFERENCE_REFERER:
+ case PREFERENCE_REFERER:
recordPhysicalWebState(LAUNCH_FROM_PREFERENCES);
break;
- case ListUrlsActivity.DIAGNOSTICS_REFERER:
+ case DIAGNOSTICS_REFERER:
recordPhysicalWebState(LAUNCH_FROM_DIAGNOSTICS);
break;
default:
@@ -291,7 +297,7 @@ public class PhysicalWebUma {
uploadTimes(PWS_REFRESH_RESOLVE_TIMES, TimeUnit.MILLISECONDS);
uploadCounts(TOTAL_URLS_INITIAL_COUNTS);
uploadCounts(TOTAL_URLS_REFRESH_COUNTS);
- uploadEnums(ACTIVITY_REFERRALS, ListUrlsActivity.REFERER_BOUNDARY);
+ uploadEnums(ACTIVITY_REFERRALS, REFERER_BOUNDARY);
uploadEnums(createStateString(LOCATION_SERVICES, LAUNCH_FROM_DIAGNOSTICS),
BOOLEAN_BOUNDARY);
uploadEnums(createStateString(LOCATION_PERMISSION, LAUNCH_FROM_DIAGNOSTICS),

Powered by Google App Engine
This is Rietveld 408576698